search

pnp / sp-dev-fx-extensions

Code samples and developer content targeted towards SharePoint Framework client-side extensions. https://aka.ms/spfx-extensions
MIT License
632 stars 826 forks source link

Sample missing README details: react-application-news-ticker #479

Open sympmarc opened 2 years ago

sympmarc commented 2 years ago

Sample

https://github.com/pnp/sp-dev-fx-extensions/tree/main/samples/react-application-news-ticker

Author(s)

@sudharsank

Suggestion

The README for this sample seems to just be the template - no details are provided.

Are you willing to help?

Yes

ghost commented 2 years ago

Thank you for reporting this issue. We will be triaging your incoming issue as soon as possible.

sympmarc commented 2 years ago

I tried to build this for @teylyn yesterday and couldn't figure it out. No docs means I have to read the code to see what's it's supposed to do. :(

teylyn commented 2 years ago

Hello @sudharsank , I have this app working in the gulp serve preview, but when I package and deploy to a site collection app catalog, then add the app to the site, nothing happens on the modern site pages. What should be done?

Rampriyar2022 commented 2 years ago

Same here, The app doesn't work and no details on how to fix it! I followed the same procedure but after the deployment nothing happens, @sudharsank can you please help?

AriGunawan commented 2 years ago

It seems that the last update (upgrade SPFx version to 1.14) didn't correctly implemented (missed readme, missed modules (react, react-dom, types, etc), changed ids, etc). I've recreated the app using the latest SPFx and tested + deployed the app and created a PR. Hope the app works again for you. *Please reinstall the app from fresh folder to make sure that you install the latest version (after my PR has been merged)