search

pnp / sp-dev-fx-extensions

Code samples and developer content targeted towards SharePoint Framework client-side extensions. https://aka.ms/spfx-extensions
MIT License
638 stars 831 forks source link

Adding form customizers as a category on the search page of the website #849

Closed martinlingstuyl closed 1 year ago

martinlingstuyl commented 1 year ago

Sample

All form customizers

Suggestion

The pnp extensions samples website has a search feature where a couple of categories are used: Application Customizers, ListView Command Sets and Field Customizers.

Form Customizers are missing though. We do have one or two in the repo, so I think it would be good to include it.

image

I'm not sure where the website repo is, otherwise I'd possibly submit a PR for this.

Are you willing to help?

Yes

ghost commented 1 year ago

Thank you for reporting this issue. We will be triaging your incoming issue as soon as possible.

martinlingstuyl commented 1 year ago

Extra interesting, I've PR'ed one Form Customizer just now. I've found one other in the repo: React Form Customizer

But I cannot find it using search on the website.

martinlingstuyl commented 1 year ago

@hugoabernier, would you know where I can submit a PR for this?

martinlingstuyl commented 1 year ago

@hugoabernier, @VesaJuvonen, any of you an idea about this issue? I created two form customizer samples which don't show up on the website because of this category thing. I'd like to fix it but don't know where..

martinlingstuyl commented 1 year ago

@hugoabernier, @VesaJuvonen, any of you an idea about this issue? I created two form customizer samples which don't show up on the website because of this category thing. I'd like to fix it but don't know where..

Pinging this again @hugoabernier :-)

hugoabernier commented 1 year ago

@martinlingstuyl thanks for pinging again. As long as the sample.json for the sample says that it is a SPFX-FORM-EXTENSION under categories, the sample will show if the form extension filter at aka.ms/spfx-webparts.

"categories": [
      "SPFX-FORM-EXTENSION"
    ],

If you find a sample that's missing, feel free to submit a PR for the sample.json, or let me know the specific sample.

I hope this helps?

hugoabernier commented 1 year ago

Closing issue as solved, but please open individual issues if you find missing samples.

martinlingstuyl commented 1 year ago

Thanks for the response @hugoabernier. It turns out I was looking at the wrong github pages:

https://pnp.github.io/sp-dev-fx-extensions/

The samples are not available there.

hugoabernier commented 1 year ago

Oh, it looks like the redirect from https://pnp.github.io/sp-dev-fx-extensions/ to aka.ms/spfx-extensions I had put in place isn't working! Good catch!

martinlingstuyl commented 1 year ago

So that's it! Nice, now it's completely cleared up!