search

pnp / sp-dev-fx-property-controls

Reusable SPFx property pane controls - Open source initiative
https://pnp.github.io/sp-dev-fx-property-controls/
MIT License
233 stars 151 forks source link

certain custom components in onCustomRender not functioning as expected #458

Open DA-Mena opened 2 years ago

DA-Mena commented 2 years ago

Category

Version

Please specify what version of the library you are using: [3.7.0]

Expected / Desired Behavior / Question

When using custom render prop to render a 3rd party react text editor (TinyMCE), sub modals that get produced under that component should work properly

Observed Behavior

TinyMCE has problems with focus when being used inside modal-like elements and input fields aren't selectable

Steps to Reproduce

Use TinyMCE v5 on as a custom field for custom render and try a plugin such as inserting links, embedding, etc.

Reason why I marked it as an enhancement is that I have a workaround and that was cloning the source and adding an additional prop to the Panel component being used in PropertyFieldCollectionDataHost.tsx

focusTrapZoneProps={ disabled=true, disableFirstFocus=true }

Can an additional prop be made in the collection data interface to pass in custom Panel props?

ghost commented 2 years ago

Thank you for reporting this issue. We will be triaging your incoming issue as soon as possible.

AJIXuMuK commented 1 year ago

@DA-Mena - sorry for the late reply. Could you please submit a PR with the changes you need? If I understand correctly, you already have an implementation locally.

Thanks!