search

pnp / sp-dev-fx-vs-extension

Visual Studio extension work around SPFx together with community
MIT License
56 stars 25 forks source link

Added support for @microsoft/generator-sharepoint@1.1.0 and SharePoint Framework Extensions #11

Closed phawrylak closed 6 years ago

phawrylak commented 7 years ago
Q A
Bug fix? yes
New feature? yes
New sample? no
Related issues? fixes #10

What's in this Pull Request?

  1. Added support for @microsoft/generator-sharepoint@1.1.0. I'm a little late here because the patch appeared during my development, but I believe that this solution is more comprehensive.
  2. Added support for SharePoint Framework Extensions (Preview) - unfortunately this will not work until Microsoft fixes bug in Yeoman generator parameters. I have implemented this in the same project template wizard (Component Type and Extension Type combos with proper hiding). I can change this implementation to separate project templates, if needed.
  3. Major code refactor - improved command string generation (regex instead of string template), added proper disposal of forms, fixed "Cancel" implementation using DialogResult and WizardCancelledException (there were issues with previous fix - for example on window close and in web part item creation), fixed Generate button disable behavior and many other code improvements.

Sorry for including many changes in one PR, but I refactored this code during implemention of Extensions support.

pschaeflein commented 7 years ago

Thanks for your contribution Pawel.

Since the new extensions are in preview, we will not be including them in the master branch. Once we get the branches sorted, we can review this PR. I will leave it open for now, but eventually it will be closed (unless I can figure out a way to re-target the destination branch).

eshupps commented 7 years ago

Reference commit f826eb7 and comments on Issue #10. Due to the wide variance between those updates and this PR, along with support for extensions being deferred until a stable release of the generator is available, we won't be merging this PR; however, note that we did include some of the optimizations from the refactoring, including inline property declarations and streamlined command string operations (although we chose to preserve the string template implementation), so these contributions are much appreciated. We will be creating new dev branches going forward to support preview releases so please feel free to contribute to those when they are available.

pschaeflein commented 6 years ago

Changes incorporated into v1.3.2