search

pnp / sp-dev-fx-vs-extension

Visual Studio extension work around SPFx together with community
MIT License
56 stars 25 forks source link

Visual Studio Crash in cancel #7 #8

Closed bonm014 closed 6 years ago

bonm014 commented 7 years ago
Q A
Bug fix? yes
New feature? no
New sample? no
Related issues? #7

What's in this Pull Request?

I made a modification that the cancel button is working correctly. I have also added the DialogResult functionality to check the status of the wizard form

bonm014 commented 7 years ago

You are quick! :-D I thought I would help with the cancel action of the form

eshupps commented 7 years ago

Thanks for the assist. We just happened to be on top of it today in support of the initial announcement. We'll leave this PR as is for the moment to get additional feedback - we used slightly different methods to handle the form cancel event so let's see which people prefer and possibly merge the changes down the line.

pschaeflein commented 6 years ago

This PR targets an older version.