search

pnp / sp-dev-fx-webparts

SharePoint Framework web part, Teams tab, personal app, app page samples
http://aka.ms/spfx-webparts
MIT License
2.03k stars 3.84k forks source link

Error - [tslint] No valid rules have been specified for TypeScript files #1201

Closed tejasthite closed 4 years ago

tejasthite commented 4 years ago

Category

Authors

@hugoabernier - Help wanted on this @wobba

Expected behavior to build the pckg after executing it

Observed Behavior

Does not bundle the solution as required / execute as required due to error message "Error - [tslint] No valid rules have been specified for TypeScript files"

Steps to Reproduce

C:\Users\tejast\Documents\GitHub\sp-dev-fx-webparts\samples\react-script-editor>gulp bundle --ship Build target: SHIP [17:46:26] Using gulpfile ~\Documents\GitHub\sp-dev-fx-webparts\samples\react-script-editor\gulpfile.js [17:46:26] Starting gulp [17:46:26] Starting 'bundle'... [17:46:27] Starting subtask 'configure-sp-build-rig'... [17:46:27] Finished subtask 'configure-sp-build-rig' after 4.89 ms [17:46:27] Starting subtask 'pre-copy'... [17:46:27] Finished subtask 'pre-copy' after 58 ms [17:46:27] Starting subtask 'copy-static-assets'... [17:46:27] Starting subtask 'sass'... [17:46:27] Finished subtask 'copy-static-assets' after 82 ms [17:46:27] Finished subtask 'sass' after 189 ms [17:46:27] Starting subtask 'tslint'... [17:46:28] [tslint] tslint version: 5.12.1 [17:46:28] Starting subtask 'tsc'... [17:46:28] [tsc] typescript version: 3.2.4 [17:46:30] Finished subtask 'tsc' after 2.14 s [17:46:30] Error - [tslint] No valid rules have been specified for TypeScript files [17:46:30] Finished subtask 'tslint' after 3.16 s [17:46:30] Starting subtask 'post-copy'... [17:46:30] Finished subtask 'post-copy' after 7.49 ms [17:46:30] Starting subtask 'collectLocalizedResources'... [17:46:30] Finished subtask 'collectLocalizedResources' after 4.02 ms [17:46:30] Starting subtask 'configure-webpack'... [17:46:31] Finished subtask 'configure-webpack' after 1.49 s [17:46:31] Starting subtask 'webpack'... [17:46:37] Finished subtask 'webpack' after 5.05 s [17:46:37] Starting subtask 'configure-webpack-external-bundling'... [17:46:37] Finished subtask 'configure-webpack-external-bundling' after 9.58 ms [17:46:37] Starting subtask 'copy-assets'... [17:46:37] Finished subtask 'copy-assets' after 492 ms [17:46:37] Starting subtask 'write-manifests'... [17:46:39] Finished subtask 'write-manifests' after 1.86 s [17:46:39] Finished 'bundle' after 12 s [17:46:39] ==================[ Finished ]================== Error - [tslint] No valid rules have been specified for TypeScript files [17:46:40] Project pzl-script-editor version:1.0.0 [17:46:40] Build tools version:3.12.1 [17:46:40] Node version:v10.19.0 [17:46:40] Total duration:18 s [17:46:40] Task errors:1 The build failed because a task wrote output to stderr. Exiting with exit code: 1

C:\Users\tejast\Documents\GitHub\sp-dev-fx-webparts\samples\react-script-editor>

(DELETE THIS PARAGRAPH AFTER READING)

Submission Guidelines

  • All suggestions or bugs are welcome, please let us know what's on your mind.
  • If you are reporting an issue around any of the samples, please ensure that you have clear reference on the sample and possibly code file, which should be fixed.
  • If you have technical questions about the framework, we’ll be monitoring #spfx, #spfx-webparts, and #spfx-tooling on (SharePoint StackExchange)> [http://sharepoint.stackexchange.com/]. You can also alternatively submit your question to (SharePoint Developer group)> [https://network.office.com/t5/SharePoint-Developer/bd-p/SharePointDev] at Office Network.
  • Remember to include sufficient details and context.
  • If you have multiple suggestions or bugs please submit them in separate bugs so we can track resolution.
ghost commented 4 years ago

Thank you for reporting this issue. We will be triaging your incoming issue as soon as possible.

wobba commented 4 years ago

Can you share spfx version and environment? Did you try ´gulp clean´ and ´npm dedupe´ before building?

tejasthite commented 4 years ago

Okay i started Back with building my system Fresh and again tried installing the react-script-editor and below is what i am stuck on now @wobba, really need to get all this up and running asap. Thank you

PS C:\code\sp-dev-fx-webparts\samples\react-script-editor> npm install npm WARN deprecated connect@2.30.2: connect 2.x series is deprecated npm WARN deprecated core-js@2.6.11: core-js@<3 is no longer maintained and not recommended for usage due to the number of issues. Please, upgrade your dependencies to the actual version of core-js@3. npm WARN deprecated request@2.88.2: request has been deprecated, see https://github.com/request/request/issues/3142 npm WARN deprecated phantomjs-prebuilt@2.1.16: this package is now deprecated npm WARN deprecated gulp-util@2.2.20: gulp-util is deprecated - replace it, following the guidelines at https://medium.com/gulpjs/gulp-util-ca3b1f9f9ac5 npm WARN deprecated json3@3.3.2: Please use the native JSON object instead of JSON 3 npm WARN deprecated istanbul@0.4.5: This module is no longer maintained, try this instead: npm WARN deprecated npm i nyc npm WARN deprecated Visit https://istanbul.js.org/integrations for other alternatives. npm WARN deprecated samsam@1.1.2: This package has been deprecated in favour of @sinonjs/samsam npm WARN deprecated formatio@1.1.1: This package is unmaintained. Use @sinonjs/formatio instead npm WARN deprecated browserslist@1.3.6: Browserslist 2 could fail on reading Browserslist >3.0 config used in other tools. npm WARN deprecated request@2.69.0: request has been deprecated, see https://github.com/request/request/issues/3142 npm WARN deprecated node-uuid@1.4.8: Use uuid module instead npm WARN deprecated tough-cookie@2.2.2: ReDoS vulnerability parsing Set-Cookie https://nodesecurity.io/advisories/130 npm WARN deprecated hawk@3.1.3: This module moved to @hapi/hawk. Please make sure to switch over as this distribution is no longer supported and may contain bugs and critical security issues. npm WARN deprecated sntp@1.0.9: This module moved to @hapi/sntp. Please make sure to switch over as this distribution is no longer supported and may contain bugs and critical security issues. npm WARN deprecated boom@2.10.1: This version has been deprecated in accordance with the hapi support policy (hapi.im/support). Please upgrade to the latest version to get the best features, bug fixes, and security patches. If you are unable to upgrade at this time, paid support is available for older versions (hapi.im/commercial). npm WARN deprecated cryptiles@2.0.5: This version has been deprecated in accordance with the hapi support policy (hapi.im/support). Please upgrade to the latest version to get the best features, bug fixes, and security patches. If you are unable to upgrade at this time, paid support is available for older versions (hapi.im/commercial). npm WARN deprecated hoek@2.16.3: This version has been deprecated in accordance with the hapi support policy (hapi.im/support). Please upgrade to the latest version to get the best features, bug fixes, and security patches. If you are unable to upgrade at this time, paid support is available for older versions (hapi.im/commercial). npm WARN deprecated browserslist@1.7.7: Browserslist 2 could fail on reading Browserslist >3.0 config used in other tools. npm WARN deprecated @types/log4js@2.3.5: This is a stub types definition for log4js (https://github.com/nomiddlename/log4js-node). log4js provides its own type definitions, so you don't need @types/log4js installed!

deasync@0.1.19 install C:\code\sp-dev-fx-webparts\samples\react-script-editor\node_modules\deasync node ./build.js

win32-x64-node-10 exists; testing Binary is fine; exiting

node-sass@4.13.1 install C:\code\sp-dev-fx-webparts\samples\react-script-editor\node_modules\node-sass node scripts/install.js

Downloading binary from https://github.com/sass/node-sass/releases/download/v4.13.1/win32-x64-64_binding.node Download complete ] - : Binary saved to C:\code\sp-dev-fx-webparts\samples\react-script-editor\node_modules\node-sass\vendor\win32-x64-64\binding.node Caching binary to C:\Users\tejast\AppData\Roaming\npm-cache\node-sass\4.13.1\win32-x64-64_binding.node

phantomjs-prebuilt@2.1.16 install C:\code\sp-dev-fx-webparts\samples\react-script-editor\node_modules\phantomjs-prebuilt node install.js

PhantomJS not found on PATH Downloading https://github.com/Medium/phantomjs/releases/download/v2.1.1/phantomjs-2.1.1-windows.zip Saving to C:\Users\tejast\AppData\Local\Temp\phantomjs\phantomjs-2.1.1-windows.zip Receiving... [=======================================-] 98% Received 17767K total. Extracting zip contents Removing C:\code\sp-dev-fx-webparts\samples\react-script-editor\node_modules\phantomjs-prebuilt\lib\phantom Copying extracted folder C:\Users\tejast\AppData\Local\Temp\phantomjs\phantomjs-2.1.1-windows.zip-extract-1586797677764\phantomjs-2.1.1-windows -> C:\code\sp-dev-fx-webparts\samples\react-script-editor\node_modules\phantomjs-prebuilt\lib\phantom Writing location.js file Done. Phantomjs binary available at C:\code\sp-dev-fx-webparts\samples\react-script-editor\node_modules\phantomjs-prebuilt\lib\phantom\bin\phantomjs.exe

@microsoft/sp-loader@1.4.1 install C:\code\sp-dev-fx-webparts\samples\react-script-editor\node_modules\@microsoft\sp-application-base\node_modules\@microsoft\sp-loader node npm-postinstall.js

@microsoft/sp-loader@1.4.1 install C:\code\sp-dev-fx-webparts\samples\react-script-editor\node_modules\@microsoft\sp-component-base\node_modules\@microsoft\sp-loader node npm-postinstall.js

@microsoft/sp-loader@1.4.1 install C:\code\sp-dev-fx-webparts\samples\react-script-editor\node_modules\@microsoft\sp-extension-base\node_modules\@microsoft\sp-loader node npm-postinstall.js

@microsoft/sp-loader@1.4.1 install C:\code\sp-dev-fx-webparts\samples\react-script-editor\node_modules\@microsoft\sp-webpart-workbench\node_modules\@microsoft\sp-loader node npm-postinstall.js

@microsoft/sp-loader@1.4.1 install C:\code\sp-dev-fx-webparts\samples\react-script-editor\node_modules\@microsoft\sp-webpart-base\node_modules\@microsoft\sp-loader node npm-postinstall.js

core-js@2.6.11 postinstall C:\code\sp-dev-fx-webparts\samples\react-script-editor\node_modules\babel-register\node_modules\core-js node -e "try{require('./postinstall')}catch(e){}"

Thank you for using core-js ( https://github.com/zloirock/core-js ) for polyfilling JavaScript standard library!

The project needs your help! Please consider supporting of core-js on Open Collective or Patreon:

https://opencollective.com/core-js https://www.patreon.com/zloirock

Also, the author of core-js ( https://github.com/zloirock ) is looking for a good job -)

core-js@2.6.11 postinstall C:\code\sp-dev-fx-webparts\samples\react-script-editor\node_modules\babel-runtime\node_modules\core-js node -e "try{require('./postinstall')}catch(e){}"

core-js@2.6.11 postinstall C:\code\sp-dev-fx-webparts\samples\react-script-editor\node_modules\karma\node_modules\core-js node -e "try{require('./postinstall')}catch(e){}"

spawn-sync@1.0.15 postinstall C:\code\sp-dev-fx-webparts\samples\react-script-editor\node_modules\spawn-sync node postinstall

uglifyjs-webpack-plugin@0.4.6 postinstall C:\code\sp-dev-fx-webparts\samples\react-script-editor\node_modules\uglifyjs-webpack-plugin node lib/post_install.js

node-sass@4.13.1 postinstall C:\code\sp-dev-fx-webparts\samples\react-script-editor\node_modules\node-sass node scripts/build.js

Binary found at C:\Code\sp-dev-fx-webparts\samples\react-script-editor\node_modules\node-sass\vendor\win32-x64-64\binding.node Testing binary Binary is fine npm WARN notsup Unsupported engine for karma@0.13.22: wanted: {"node":"0.10 || 0.12 || 4 || 5"} (current: {"node":"10.20.1","npm":"6.14.4"}) npm WARN notsup Not compatible with your version of node/npm: karma@0.13.22 npm WARN optional SKIPPING OPTIONAL DEPENDENCY: fsevents@^1.0.0 (node_modules\chokidar\node_modules\fsevents): npm WARN notsup SKIPPING OPTIONAL DEPENDENCY: Unsupported platform for fsevents@1.2.12: wanted {"os":"darwin","arch":"any"} (current: {"os":"win32","arch":"x64"}) npm WARN optional SKIPPING OPTIONAL DEPENDENCY: abbrev@1.1.1 (node_modules\fsevents\node_modules\abbrev): npm WARN enoent SKIPPING OPTIONAL DEPENDENCY: ENOENT: no such file or directory, rename 'C:\code\sp-dev-fx-webparts\samples\react-script-editor\node_modules\fsevents\node_modules\abbrev' -> 'C:\code\sp-dev-fx-webparts\samples\react-script-editor\node_modules\fsevents\node_modules.abbrev.DELETE' npm WARN optional SKIPPING OPTIONAL DEPENDENCY: ansi-regex@2.1.1 (node_modules\fsevents\node_modules\ansi-regex): npm WARN enoent SKIPPING OPTIONAL DEPENDENCY: ENOENT: no such file or directory, rename 'C:\code\sp-dev-fx-webparts\samples\react-script-editor\node_modules\fsevents\node_modules\ansi-regex' -> 'C:\code\sp-dev-fx-webparts\samples\react-script-editor\node_modules\fsevents\node_modules.ansi-regex.DELETE' npm WARN optional SKIPPING OPTIONAL DEPENDENCY: aproba@1.2.0 (node_modules\fsevents\node_modules\aproba): npm WARN enoent SKIPPING OPTIONAL DEPENDENCY: ENOENT: no such file or directory, rename 'C:\code\sp-dev-fx-webparts\samples\react-script-editor\node_modules\fsevents\node_modules\aproba' -> 'C:\code\sp-dev-fx-webparts\samples\react-script-editor\node_modules\fsevents\node_modules.aproba.DELETE' npm WARN optional SKIPPING OPTIONAL DEPENDENCY: balanced-match@1.0.0 (node_modules\fsevents\node_modules\balanced-match): npm WARN enoent SKIPPING OPTIONAL DEPENDENCY: ENOENT: no such file or directory, rename 'C:\code\sp-dev-fx-webparts\samples\react-script-editor\node_modules\fsevents\node_modules\balanced-match' -> 'C:\code\sp-dev-fx-webparts\samples\react-script-editor\node_modules\fsevents\node_modules.balanced-match.DELETE' npm WARN optional SKIPPING OPTIONAL DEPENDENCY: chownr@1.1.4 (node_modules\fsevents\node_modules\chownr): npm WARN enoent SKIPPING OPTIONAL DEPENDENCY: ENOENT: no such file or directory, rename 'C:\code\sp-dev-fx-webparts\samples\react-script-editor\node_modules\fsevents\node_modules\chownr' -> 'C:\code\sp-dev-fx-webparts\samples\react-script-editor\node_modules\fsevents\node_modules.chownr.DELETE' npm WARN optional SKIPPING OPTIONAL DEPENDENCY: code-point-at@1.1.0 (node_modules\fsevents\node_modules\code-point-at): npm WARN enoent SKIPPING OPTIONAL DEPENDENCY: ENOENT: no such file or directory, rename 'C:\code\sp-dev-fx-webparts\samples\react-script-editor\node_modules\fsevents\node_modules\code-point-at' -> 'C:\code\sp-dev-fx-webparts\samples\react-script-editor\node_modules\fsevents\node_modules.code-point-at.DELETE' npm WARN optional SKIPPING OPTIONAL DEPENDENCY: concat-map@0.0.1 (node_modules\fsevents\node_modules\concat-map): npm WARN enoent SKIPPING OPTIONAL DEPENDENCY: ENOENT: no such file or directory, rename 'C:\code\sp-dev-fx-webparts\samples\react-script-editor\node_modules\fsevents\node_modules\concat-map' -> 'C:\code\sp-dev-fx-webparts\samples\react-script-editor\node_modules\fsevents\node_modules.concat-map.DELETE' npm WARN optional SKIPPING OPTIONAL DEPENDENCY: console-control-strings@1.1.0 (node_modules\fsevents\node_modules\console-control-strings): npm WARN enoent SKIPPING OPTIONAL DEPENDENCY: ENOENT: no such file or directory, rename 'C:\code\sp-dev-fx-webparts\samples\react-script-editor\node_modules\fsevents\node_modules\console-control-strings' -> 'C:\code\sp-dev-fx-webparts\samples\react-script-editor\node_modules\fsevents\node_modules.console-control-strings.DELETE' npm WARN optional SKIPPING OPTIONAL DEPENDENCY: core-util-is@1.0.2 (node_modules\fsevents\node_modules\core-util-is): npm WARN enoent SKIPPING OPTIONAL DEPENDENCY: ENOENT: no such file or directory, rename 'C:\code\sp-dev-fx-webparts\samples\react-script-editor\node_modules\fsevents\node_modules\core-util-is' -> 'C:\code\sp-dev-fx-webparts\samples\react-script-editor\node_modules\fsevents\node_modules.core-util-is.DELETE' npm WARN optional SKIPPING OPTIONAL DEPENDENCY: deep-extend@0.6.0 (node_modules\fsevents\node_modules\deep-extend): npm WARN enoent SKIPPING OPTIONAL DEPENDENCY: ENOENT: no such file or directory, rename 'C:\code\sp-dev-fx-webparts\samples\react-script-editor\node_modules\fsevents\node_modules\deep-extend' -> 'C:\code\sp-dev-fx-webparts\samples\react-script-editor\node_modules\fsevents\node_modules.deep-extend.DELETE' npm WARN optional SKIPPING OPTIONAL DEPENDENCY: delegates@1.0.0 (node_modules\fsevents\node_modules\delegates): npm WARN enoent SKIPPING OPTIONAL DEPENDENCY: ENOENT: no such file or directory, rename 'C:\code\sp-dev-fx-webparts\samples\react-script-editor\node_modules\fsevents\node_modules\delegates' -> 'C:\code\sp-dev-fx-webparts\samples\react-script-editor\node_modules\fsevents\node_modules.delegates.DELETE' npm WARN optional SKIPPING OPTIONAL DEPENDENCY: detect-libc@1.0.3 (node_modules\fsevents\node_modules\detect-libc): npm WARN enoent SKIPPING OPTIONAL DEPENDENCY: ENOENT: no such file or directory, rename 'C:\code\sp-dev-fx-webparts\samples\react-script-editor\node_modules\fsevents\node_modules\detect-libc' -> 'C:\code\sp-dev-fx-webparts\samples\react-script-editor\node_modules\fsevents\node_modules.detect-libc.DELETE' npm WARN optional SKIPPING OPTIONAL DEPENDENCY: fs.realpath@1.0.0 (node_modules\fsevents\node_modules\fs.realpath): npm WARN enoent SKIPPING OPTIONAL DEPENDENCY: ENOENT: no such file or directory, rename 'C:\code\sp-dev-fx-webparts\samples\react-script-editor\node_modules\fsevents\node_modules\fs.realpath' -> 'C:\code\sp-dev-fx-webparts\samples\react-script-editor\node_modules\fsevents\node_modules.fs.realpath.DELETE' npm WARN optional SKIPPING OPTIONAL DEPENDENCY: has-unicode@2.0.1 (node_modules\fsevents\node_modules\has-unicode): npm WARN enoent SKIPPING OPTIONAL DEPENDENCY: ENOENT: no such file or directory, rename 'C:\code\sp-dev-fx-webparts\samples\react-script-editor\node_modules\fsevents\node_modules\has-unicode' -> 'C:\code\sp-dev-fx-webparts\samples\react-script-editor\node_modules\fsevents\node_modules.has-unicode.DELETE' npm WARN optional SKIPPING OPTIONAL DEPENDENCY: inherits@2.0.4 (node_modules\fsevents\node_modules\inherits): npm WARN enoent SKIPPING OPTIONAL DEPENDENCY: ENOENT: no such file or directory, rename 'C:\code\sp-dev-fx-webparts\samples\react-script-editor\node_modules\fsevents\node_modules\inherits' -> 'C:\code\sp-dev-fx-webparts\samples\react-script-editor\node_modules\fsevents\node_modules.inherits.DELETE' npm WARN optional SKIPPING OPTIONAL DEPENDENCY: ini@1.3.5 (node_modules\fsevents\node_modules\ini): npm WARN enoent SKIPPING OPTIONAL DEPENDENCY: ENOENT: no such file or directory, rename 'C:\code\sp-dev-fx-webparts\samples\react-script-editor\node_modules\fsevents\node_modules\ini' -> 'C:\code\sp-dev-fx-webparts\samples\react-script-editor\node_modules\fsevents\node_modules.ini.DELETE' npm WARN optional SKIPPING OPTIONAL DEPENDENCY: isarray@1.0.0 (node_modules\fsevents\node_modules\isarray): npm WARN enoent SKIPPING OPTIONAL DEPENDENCY: ENOENT: no such file or directory, rename 'C:\code\sp-dev-fx-webparts\samples\react-script-editor\node_modules\fsevents\node_modules\isarray' -> 'C:\code\sp-dev-fx-webparts\samples\react-script-editor\node_modules\fsevents\node_modules.isarray.DELETE' npm WARN optional SKIPPING OPTIONAL DEPENDENCY: minimist@1.2.5 (node_modules\fsevents\node_modules\minimist): npm WARN enoent SKIPPING OPTIONAL DEPENDENCY: ENOENT: no such file or directory, rename 'C:\code\sp-dev-fx-webparts\samples\react-script-editor\node_modules\fsevents\node_modules\minimist' -> 'C:\code\sp-dev-fx-webparts\samples\react-script-editor\node_modules\fsevents\node_modules.minimist.DELETE' npm WARN optional SKIPPING OPTIONAL DEPENDENCY: ms@2.1.2 (node_modules\fsevents\node_modules\ms): npm WARN enoent SKIPPING OPTIONAL DEPENDENCY: ENOENT: no such file or directory, rename 'C:\code\sp-dev-fx-webparts\samples\react-script-editor\node_modules\fsevents\node_modules\ms' -> 'C:\code\sp-dev-fx-webparts\samples\react-script-editor\node_modules\fsevents\node_modules.ms.DELETE' npm WARN optional SKIPPING OPTIONAL DEPENDENCY: npm-normalize-package-bin@1.0.1 (node_modules\fsevents\node_modules\npm-normalize-package-bin): npm WARN enoent SKIPPING OPTIONAL DEPENDENCY: ENOENT: no such file or directory, rename 'C:\code\sp-dev-fx-webparts\samples\react-script-editor\node_modules\fsevents\node_modules\npm-normalize-package-bin' -> 'C:\code\sp-dev-fx-webparts\samples\react-script-editor\node_modules\fsevents\node_modules.npm-normalize-package-bin.DELETE' npm WARN optional SKIPPING OPTIONAL DEPENDENCY: number-is-nan@1.0.1 (node_modules\fsevents\node_modules\number-is-nan): npm WARN enoent SKIPPING OPTIONAL DEPENDENCY: ENOENT: no such file or directory, rename 'C:\code\sp-dev-fx-webparts\samples\react-script-editor\node_modules\fsevents\node_modules\number-is-nan' -> 'C:\code\sp-dev-fx-webparts\samples\react-script-editor\node_modules\fsevents\node_modules.number-is-nan.DELETE' npm WARN optional SKIPPING OPTIONAL DEPENDENCY: object-assign@4.1.1 (node_modules\fsevents\node_modules\object-assign): npm WARN enoent SKIPPING OPTIONAL DEPENDENCY: ENOENT: no such file or directory, rename 'C:\code\sp-dev-fx-webparts\samples\react-script-editor\node_modules\fsevents\node_modules\object-assign' -> 'C:\code\sp-dev-fx-webparts\samples\react-script-editor\node_modules\fsevents\node_modules.object-assign.DELETE' npm WARN optional SKIPPING OPTIONAL DEPENDENCY: os-homedir@1.0.2 (node_modules\fsevents\node_modules\os-homedir): npm WARN enoent SKIPPING OPTIONAL DEPENDENCY: ENOENT: no such file or directory, rename 'C:\code\sp-dev-fx-webparts\samples\react-script-editor\node_modules\fsevents\node_modules\os-homedir' -> 'C:\code\sp-dev-fx-webparts\samples\react-script-editor\node_modules\fsevents\node_modules.os-homedir.DELETE' npm WARN optional SKIPPING OPTIONAL DEPENDENCY: os-tmpdir@1.0.2 (node_modules\fsevents\node_modules\os-tmpdir): npm WARN enoent SKIPPING OPTIONAL DEPENDENCY: ENOENT: no such file or directory, rename 'C:\code\sp-dev-fx-webparts\samples\react-script-editor\node_modules\fsevents\node_modules\os-tmpdir' -> 'C:\code\sp-dev-fx-webparts\samples\react-script-editor\node_modules\fsevents\node_modules.os-tmpdir.DELETE' npm WARN optional SKIPPING OPTIONAL DEPENDENCY: path-is-absolute@1.0.1 (node_modules\fsevents\node_modules\path-is-absolute): npm WARN enoent SKIPPING OPTIONAL DEPENDENCY: ENOENT: no such file or directory, rename 'C:\code\sp-dev-fx-webparts\samples\react-script-editor\node_modules\fsevents\node_modules\path-is-absolute' -> 'C:\code\sp-dev-fx-webparts\samples\react-script-editor\node_modules\fsevents\node_modules.path-is-absolute.DELETE' npm WARN optional SKIPPING OPTIONAL DEPENDENCY: process-nextick-args@2.0.1 (node_modules\fsevents\node_modules\process-nextick-args): npm WARN enoent SKIPPING OPTIONAL DEPENDENCY: ENOENT: no such file or directory, rename 'C:\code\sp-dev-fx-webparts\samples\react-script-editor\node_modules\fsevents\node_modules\process-nextick-args' -> 'C:\code\sp-dev-fx-webparts\samples\react-script-editor\node_modules\fsevents\node_modules.process-nextick-args.DELETE' npm WARN optional SKIPPING OPTIONAL DEPENDENCY: safe-buffer@5.1.2 (node_modules\fsevents\node_modules\safe-buffer): npm WARN enoent SKIPPING OPTIONAL DEPENDENCY: ENOENT: no such file or directory, rename 'C:\code\sp-dev-fx-webparts\samples\react-script-editor\node_modules\fsevents\node_modules\safe-buffer' -> 'C:\code\sp-dev-fx-webparts\samples\react-script-editor\node_modules\fsevents\node_modules.safe-buffer.DELETE' npm WARN optional SKIPPING OPTIONAL DEPENDENCY: safer-buffer@2.1.2 (node_modules\fsevents\node_modules\safer-buffer): npm WARN enoent SKIPPING OPTIONAL DEPENDENCY: ENOENT: no such file or directory, rename 'C:\code\sp-dev-fx-webparts\samples\react-script-editor\node_modules\fsevents\node_modules\safer-buffer' -> 'C:\code\sp-dev-fx-webparts\samples\react-script-editor\node_modules\fsevents\node_modules.safer-buffer.DELETE' npm WARN optional SKIPPING OPTIONAL DEPENDENCY: sax@1.2.4 (node_modules\fsevents\node_modules\sax): npm WARN enoent SKIPPING OPTIONAL DEPENDENCY: ENOENT: no such file or directory, rename 'C:\code\sp-dev-fx-webparts\samples\react-script-editor\node_modules\fsevents\node_modules\sax' -> 'C:\code\sp-dev-fx-webparts\samples\react-script-editor\node_modules\fsevents\node_modules.sax.DELETE' npm WARN optional SKIPPING OPTIONAL DEPENDENCY: semver@5.7.1 (node_modules\fsevents\node_modules\semver): npm WARN enoent SKIPPING OPTIONAL DEPENDENCY: ENOENT: no such file or directory, rename 'C:\code\sp-dev-fx-webparts\samples\react-script-editor\node_modules\fsevents\node_modules\semver' -> 'C:\code\sp-dev-fx-webparts\samples\react-script-editor\node_modules\fsevents\node_modules.semver.DELETE' npm WARN optional SKIPPING OPTIONAL DEPENDENCY: set-blocking@2.0.0 (node_modules\fsevents\node_modules\set-blocking): npm WARN enoent SKIPPING OPTIONAL DEPENDENCY: ENOENT: no such file or directory, rename 'C:\code\sp-dev-fx-webparts\samples\react-script-editor\node_modules\fsevents\node_modules\set-blocking' -> 'C:\code\sp-dev-fx-webparts\samples\react-script-editor\node_modules\fsevents\node_modules.set-blocking.DELETE' npm WARN optional SKIPPING OPTIONAL DEPENDENCY: signal-exit@3.0.2 (node_modules\fsevents\node_modules\signal-exit): npm WARN enoent SKIPPING OPTIONAL DEPENDENCY: ENOENT: no such file or directory, rename 'C:\code\sp-dev-fx-webparts\samples\react-script-editor\node_modules\fsevents\node_modules\signal-exit' -> 'C:\code\sp-dev-fx-webparts\samples\react-script-editor\node_modules\fsevents\node_modules.signal-exit.DELETE' npm WARN optional SKIPPING OPTIONAL DEPENDENCY: strip-json-comments@2.0.1 (node_modules\fsevents\node_modules\strip-json-comments): npm WARN enoent SKIPPING OPTIONAL DEPENDENCY: ENOENT: no such file or directory, rename 'C:\code\sp-dev-fx-webparts\samples\react-script-editor\node_modules\fsevents\node_modules\strip-json-comments' -> 'C:\code\sp-dev-fx-webparts\samples\react-script-editor\node_modules\fsevents\node_modules.strip-json-comments.DELETE' npm WARN optional SKIPPING OPTIONAL DEPENDENCY: util-deprecate@1.0.2 (node_modules\fsevents\node_modules\util-deprecate): npm WARN enoent SKIPPING OPTIONAL DEPENDENCY: ENOENT: no such file or directory, rename 'C:\code\sp-dev-fx-webparts\samples\react-script-editor\node_modules\fsevents\node_modules\util-deprecate' -> 'C:\code\sp-dev-fx-webparts\samples\react-script-editor\node_modules\fsevents\node_modules.util-deprecate.DELETE' npm WARN optional SKIPPING OPTIONAL DEPENDENCY: wrappy@1.0.2 (node_modules\fsevents\node_modules\wrappy): npm WARN enoent SKIPPING OPTIONAL DEPENDENCY: ENOENT: no such file or directory, rename 'C:\code\sp-dev-fx-webparts\samples\react-script-editor\node_modules\fsevents\node_modules\wrappy' -> 'C:\code\sp-dev-fx-webparts\samples\react-script-editor\node_modules\fsevents\node_modules.wrappy.DELETE' npm WARN optional SKIPPING OPTIONAL DEPENDENCY: yallist@3.1.1 (node_modules\fsevents\node_modules\yallist): npm WARN enoent SKIPPING OPTIONAL DEPENDENCY: ENOENT: no such file or directory, rename 'C:\code\sp-dev-fx-webparts\samples\react-script-editor\node_modules\fsevents\node_modules\yallist' -> 'C:\code\sp-dev-fx-webparts\samples\react-script-editor\node_modules\fsevents\node_modules.yallist.DELETE'

added 1965 packages from 1765 contributors and audited 280886 packages in 236.864s

5 packages are looking for funding run npm fund for details

found 7694 vulnerabilities (5849 low, 427 moderate, 1411 high, 7 critical) run npm audit fix to fix them, or npm audit for details PS C:\code\sp-dev-fx-webparts\samples\react-script-editor> gulp serve gulp serve[14600]: c:\ws\src\node_contextify.cc:635: Assertion `args[1]->IsString()' failed. 1: 00007FF6DC98879A v8::internal::GCIdleTimeHandler::GCIdleTimeHandler+4506 2: 00007FF6DC963206 node::MakeCallback+4534 3: 00007FF6DC9632BF node::MakeCallback+4719 4: 00007FF6DC9374C0 node::DecodeWrite+13120 5: 00007FF6DCE94612 std::vector<v8::internal::compiler::MoveOperands __ptr64,v8::internal::ZoneAllocator<v8::internal::compiler::MoveOperands ptr64> >::_Umove+79442 6: 00007FF6DCE95779 std::vector<v8::internal::compiler::MoveOperands __ptr64,v8::internal::ZoneAllocator<v8::internal::compiler::MoveOperands __ptr64> >::_Umove+83897 7: 00007FF6DCE94ABC std::vector<v8::internal::compiler::MoveOperands * ptr64,v8::internal::ZoneAllocator<v8::internal::compiler::MoveOperands __ptr64> >::_Umove+80636 8: 00007FF6DCE949DB std::vector<v8::internal::compiler::MoveOperands ptr64,v8::internal::ZoneAllocator<v8::internal::compiler::MoveOperands * ptr64> >::_Umove+80411 9: 00000359AFDDC5C1 PS C:\code\sp-dev-fx-webparts\samples\react-script-editor>

hugoabernier commented 4 years ago

@tejasthite thank you for following up with this.

Can you try using SPFx doctor and let us know what it says?

tejasthite commented 4 years ago

@hugoabernier @wobba - I get the below, Not able to find the cmdlets for PS how can i proceed?

PS C:\Code\sp-dev-fx-webparts\samples\react-script-editor> spfx doctor spfx : The term 'spfx' is not recognized as the name of a cmdlet, function, script file, or operable program. Check the spelling of the name, or if a path was included, verify that the path is correct and try again. At line:1 char:1

hugoabernier commented 4 years ago

@tejasthite can you confirm that you installed the Office 365 CLI first?

Follow these steps:

  1. From your node.js command prompt, enter: 
    npm i -g @pnp/office365-cli
  2. Change to the current project directory
  3. Run the following command 
    o365 spfx doctor
  4. Report the results
tejasthite commented 4 years ago

Done! @hugoabernier

PS C:\Code\sp-dev-fx-webparts\samples\react-script-editor> o365 spfx doctor

Office 365 CLI SharePoint Framework doctor Verifying configuration of your system for working with the SharePoint Framework

√ SharePoint Framework v1.4.1 × Node v10.20.1 found, v^6.0.0 || ^8.0.0 required × npm v6.14.4 found, v^3.0.0 || ^4.0.0 required √ yo v3.1.1 √ gulp v4.0.2 √ bundled typescript used

Recommended fixes:

PS C:\Code\sp-dev-fx-webparts\samples\react-script-editor>

tejasthite commented 4 years ago

@hugoabernier - I fixed the recommendations with downgrading my Node.js version and installed npm i -g npm@4

Office 365 CLI SharePoint Framework doctor Verifying configuration of your system for working with the SharePoint Framework

√ SharePoint Framework v1.4.1 √ Node v8.17.0 √ npm v4.6.1 √ yo v3.1.1 √ gulp v4.0.2 √ bundled typescript used

Further to which i did run ... and this is what i get

`PS C:\Code\sp-dev-fx-webparts\samples\react-script-editor> gulp serve C:\Code\sp-dev-fx-webparts\samples\react-script-editor\node_modules\node-sass\lib\binding.js:15 throw new Error(errors.missingBinary()); ^

Error: Missing binding C:\Code\sp-dev-fx-webparts\samples\react-script-editor\node_modules\node-sass\vendor\win32-x64-57\binding.node Node Sass could not find a binding for your current environment: Windows 64-bit with Node.js 8.x

Found bindings for the following environments:

This usually happens because your environment has changed since running npm install. Run npm rebuild node-sass to download the binding for your current environment. at module.exports (C:\Code\sp-dev-fx-webparts\samples\react-script-editor\node_modules\node-sass\lib\binding.js:15:13) at Object. (C:\Code\sp-dev-fx-webparts\samples\react-script-editor\node_modules\node-sass\lib\index.js:14:35) at Module._compile (module.js:653:30) at Object.Module._extensions..js (module.js:664:10) at Module.load (module.js:566:32) at tryModuleLoad (module.js:506:12) at Function.Module._load (module.js:498:3) at Module.require (module.js:597:17) at require (internal/module.js:11:18) at Object. (C:\Code\sp-dev-fx-webparts\samples\react-script-editor\node_modules\@microsoft\gulp-core-build-sass\lib\SassTask.js:11:18) PS C:\Code\sp-dev-fx-webparts\samples\react-script-editor> npm rebuild node-sass

node-sass@4.12.0 install C:\Code\sp-dev-fx-webparts\samples\react-script-editor\node_modules\node-sass node scripts/install.js

Downloading binary from https://github.com/sass/node-sass/releases/download/v4.12.0/win32-x64-57_binding.node Download complete ] - : Binary saved to C:\Code\sp-dev-fx-webparts\samples\react-script-editor\node_modules\node-sass\vendor\win32-x64-57\binding.node Caching binary to C:\Users\tejast\AppData\Roaming\npm-cache\node-sass\4.12.0\win32-x64-57_binding.node

node-sass@4.12.0 postinstall C:\Code\sp-dev-fx-webparts\samples\react-script-editor\node_modules\node-sass node scripts/build.js

Binary found at C:\Code\sp-dev-fx-webparts\samples\react-script-editor\node_modules\node-sass\vendor\win32-x64-57\binding.node Testing binary Binary is fine node-sass@4.12.0 C:\Code\sp-dev-fx-webparts\samples\react-script-editor\node_modules\node-sass PS C:\Code\sp-dev-fx-webparts\samples\react-script-editor> gulp serve Build target: DEBUG C:\Code\sp-dev-fx-webparts\samples\react-script-editor\node_modules\@microsoft\node-core-library\lib\JsonSchema.js:178 throw new Error(prefix + os.EOL + ^

Error: JSON validation failed: C:\Code\sp-dev-fx-webparts\samples\react-script-editor\config\tslint.json

Error: #/ (Defines configuration options for the...) Additional properties not allowed: lintConfig,useDefaultConfigAsBase,removeExistingRules,displayAsWarning at validateObjectWithCallback (C:\Code\sp-dev-fx-webparts\samples\react-script-editor\node_modules\@microsoft\node-core-library\lib\JsonSchema.js:178:19) at JsonSchema.validateObjectWithCallback (C:\Code\sp-dev-fx-webparts\samples\react-script-editor\node_modules\@microsoft\node-core-library\lib\JsonSchema.js:193:13) at JsonSchema.validateObject (C:\Code\sp-dev-fx-webparts\samples\react-script-editor\node_modules\@microsoft\node-core-library\lib\JsonSchema.js:175:14) at TslintCmdTask._readConfigFile (C:\Code\sp-dev-fx-webparts\samples\react-script-editor\node_modules\@microsoft\gulp-core-build\lib\tasks\GulpTask.js:311:28) at TslintCmdTask.onRegister (C:\Code\sp-dev-fx-webparts\samples\react-script-editor\node_modules\@microsoft\gulp-core-build\lib\tasks\GulpTask.js:87:32) at Object.initialize (C:\Code\sp-dev-fx-webparts\samples\react-script-editor\node_modules\@microsoft\gulp-core-build\lib\index.js:300:24) at SPWebBuildRig.initialize (C:\Code\sp-dev-fx-webparts\samples\react-script-editor\node_modules\@microsoft\sp-build-common\lib\BuildRig.js:61:19) at SPWebBuildRig.initialize (C:\Code\sp-dev-fx-webparts\samples\react-script-editor\node_modules\@microsoft\sp-build-common\lib\SPBuildRig.js:30:15) at Object.exports.initialize (C:\Code\sp-dev-fx-webparts\samples\react-script-editor\node_modules\@microsoft\sp-build-web\lib\index.js:22:17) at Object. (C:\Code\sp-dev-fx-webparts\samples\react-script-editor\gulpfile.js:25:7) at Module._compile (module.js:653:30) at Object.Module._extensions..js (module.js:664:10) at Module.load (module.js:566:32) at tryModuleLoad (module.js:506:12) at Function.Module._load (module.js:498:3) at Module.require (module.js:597:17) PS C:\Code\sp-dev-fx-webparts\samples\react-script-editor>`

wobba commented 4 years ago

@tejasthite can you try to build any of the other samples? Do they work? I simply cannot repro your issue. And it requires SPFx v1.10.0, not 1.4.1. The react-script-editor-onprem sample can be built using v1.4.1.

tejasthite commented 4 years ago

@wobba I had tried one of the Calendar feed sample earlier months back which worked well, If you want i can again give that a try? And it requires SPFx v1.10.0, not 1.4.1 - Will this need a upgrade? and how can i achieve it?

wobba commented 4 years ago

@tejasthite What does npm ls -g --depth=0 @microsoft/generator-sharepoint show in your system?

tejasthite commented 4 years ago

@wobba PS C:\Code\sp-dev-fx-webparts\samples\react-script-editor> npm ls -g --depth=0 @microsoft/generator-sharepoint C:\Users\tejast\AppData\Roaming\npm `-- @microsoft/generator-sharepoint@1.10.0

PS C:\Code\sp-dev-fx-webparts\samples\react-script-editor>

wobba commented 4 years ago

Then I'm unsure why npm i and building fails for you as you seem to have the right version. Does any of the steps at https://www.c-sharpcorner.com/article/spfx-upgrading-to-latest-version-1-9-1-issues-and-solutions/ help you to resolve the issue?

tejasthite commented 4 years ago

@wobba Much appreciate all you time with this, I will try to follow the article and see how it goes! @hugoabernier any further inputs from your end would help i was really in need of this very much which will help me over come most of the challenges Thank you

tejasthite commented 4 years ago

@wobba - I am still left with this after following the article. Thank you Error: JSON validation failed: C:\Code\sp-dev-fx-webparts\samples\react-script-editor\config\tslint.json

Error: #/ (Defines configuration options for the...) Additional properties not allowed: lintConfig,useDefaultConfigAsBase,removeExistingRules,displayAsWarning at validateObjectWithCallback (C:\Code\sp-dev-fx-webparts\samples\react-script-editor\node_modules\@microsoft\node-core-library\lib\JsonSchema.js:178:19) at JsonSchema.validateObjectWithCallback (C:\Code\sp-dev-fx-webparts\samples\react-script-editor\node_modules\@microsoft\node-core-library\lib\JsonSchema.js:193:13) at JsonSchema.validateObject (C:\Code\sp-dev-fx-webparts\samples\react-script-editor\node_modules\@microsoft\node-core-library\lib\JsonSchema.js:175:14) at TslintCmdTask._readConfigFile (C:\Code\sp-dev-fx-webparts\samples\react-script-editor\node_modules\@microsoft\gulp-core-build\lib\tasks\GulpTask.js:311:28) at TslintCmdTask.onRegister (C:\Code\sp-dev-fx-webparts\samples\react-script-editor\node_modules\@microsoft\gulp-core-build\lib\tasks\GulpTask.js:87:32) at Object.initialize (C:\Code\sp-dev-fx-webparts\samples\react-script-editor\node_modules\@microsoft\gulp-core-build\lib\index.js:300:24) at SPWebBuildRig.initialize (C:\Code\sp-dev-fx-webparts\samples\react-script-editor\node_modules\@microsoft\sp-build-common\lib\BuildRig.js:61:19) at SPWebBuildRig.initialize (C:\Code\sp-dev-fx-webparts\samples\react-script-editor\node_modules\@microsoft\sp-build-common\lib\SPBuildRig.js:30:15) at Object.exports.initialize (C:\Code\sp-dev-fx-webparts\samples\react-script-editor\node_modules\@microsoft\sp-build-web\lib\index.js:22:17) at Object. (C:\Code\sp-dev-fx-webparts\samples\react-script-editor\gulpfile.js:25:7) at Module._compile (module.js:653:30) at Object.Module._extensions..js (module.js:664:10) at Module.load (module.js:566:32) at tryModuleLoad (module.js:506:12) at Function.Module._load (module.js:498:3) at Module.require (module.js:597:17)

tejasthite commented 4 years ago

@wobba OK i followed this article - https://knowledge-junction.com/2018/10/09/o365-sharepoint-online-spfx-component-all-gulp-commands-failed-error-json-validation-failed-webpartsconfigtslint-json/ It got me Rid of the message - But i now have the same challenge from where i started

`PS C:\Code\sp-dev-fx-webparts\samples\react-script-editor> gulp serve Build target: DEBUG [17:50:36] Using gulpfile C:\Code\sp-dev-fx-webparts\samples\react-script-editor\gulpfile.js [17:50:36] Starting gulp [17:50:36] Starting 'serve'... [17:50:36] Starting subtask 'configure-sp-build-rig'... [17:50:36] Finished subtask 'configure-sp-build-rig' after 13 ms [17:50:36] Starting subtask 'spfx-serve'... [17:50:36] [spfx-serve] To load your scripts, use this query string: ?debug=true&noredir=true&debugManifestsFile=https://localhost:4321/temp/manifests.js [17:50:36] Starting server... Starting api server on port 5432. Registring api: /workbench Registring api: / [17:50:37] Finished subtask 'spfx-serve' after 328 ms [17:50:37] Starting subtask 'pre-copy'... [17:50:37] Finished subtask 'pre-copy' after 49 ms [17:50:37] Starting subtask 'copy-static-assets'... [17:50:37] Starting subtask 'sass'... [17:50:37] Server started https://localhost:4321 [17:50:37] LiveReload started on port 35729 [17:50:37] Running server [17:50:37] Opening https://localhost:5432/workbench using the default OS app [17:50:37] Finished subtask 'copy-static-assets' after 112 ms [17:50:37] Finished subtask 'sass' after 239 ms [17:50:37] Starting subtask 'tslint'... [17:50:38] [tslint] tslint version: 5.12.1 [17:50:38] Starting subtask 'tsc'... [17:50:38] [tsc] typescript version: 3.2.4 Request: [::1] '/workbench' Request: '/temp/workbench.html' Request: '/temp/manifests.js' Request: '/temp/workbench-packages/@microsoft_sp-webpart-workbench/local-workbench/sp-webpart-workbench-assembly_default.js' Request: '/temp/workbench-packages/@microsoft_sp-webpart-workbench/lib/api/workbenchInit.js' [17:50:40] Error - [tslint] No valid rules have been specified for TypeScript files [17:50:40] Finished subtask 'tslint' after 2.93 s [17:50:40] Finished subtask 'tsc' after 2.17 s [17:50:40] Starting subtask 'post-copy'... [17:50:40] Finished subtask 'post-copy' after 655 μs [17:50:40] Starting subtask 'collectLocalizedResources'... [17:50:40] Finished subtask 'collectLocalizedResources' after 783 μs [17:50:40] Starting subtask 'configure-webpack'... [17:50:41] Finished subtask 'configure-webpack' after 728 ms [17:50:41] Starting subtask 'webpack'... [17:50:41] Error - [webpack] 'dist': Entry module not found: Error: Can't resolve 'C:\Code\sp-dev-fx-webparts\samples\react-script-editor\lib\webparts\scriptEditor\ScriptEditorWebPart.js' in 'C:\Code\sp-dev-fx-webparts\samples\react-script-editor' resolve 'C:\Code\sp-dev-fx-webparts\samples\react-script-editor\lib\webparts\scriptEditor\ScriptEditorWebPart.js' in 'C:\Code\sp-dev-fx-webparts\samples\react-script-editor' using description file: C:\Code\sp-dev-fx-webparts\samples\react-script-editor\package.json (relative path: .) Field 'browser' doesn't contain a valid alias configuration using description file: C:\Code\sp-dev-fx-webparts\samples\react-script-editor\package.json (relative path: ./lib/webparts/scriptEditor/ScriptEditorWebPart.js) no extension Field 'browser' doesn't contain a valid alias configuration C:\Code\sp-dev-fx-webparts\samples\react-script-editor\lib\webparts\scriptEditor\ScriptEditorWebPart.js doesn't exist .wasm Field 'browser' doesn't contain a valid alias configuration C:\Code\sp-dev-fx-webparts\samples\react-script-editor\lib\webparts\scriptEditor\ScriptEditorWebPart.js.wasm doesn't exist .mjs Field 'browser' doesn't contain a valid alias configuration C:\Code\sp-dev-fx-webparts\samples\react-script-editor\lib\webparts\scriptEditor\ScriptEditorWebPart.js.mjs doesn't exist .js Field 'browser' doesn't contain a valid alias configuration C:\Code\sp-dev-fx-webparts\samples\react-script-editor\lib\webparts\scriptEditor\ScriptEditorWebPart.js.js doesn't exist .json Field 'browser' doesn't contain a valid alias configuration C:\Code\sp-dev-fx-webparts\samples\react-script-editor\lib\webparts\scriptEditor\ScriptEditorWebPart.js.json doesn't exist as directory C:\Code\sp-dev-fx-webparts\samples\react-script-editor\lib\webparts\scriptEditor\ScriptEditorWebPart.js doesn't exist

[17:50:41] Finished subtask 'webpack' after 180 ms [17:50:41] Starting subtask 'configure-webpack-external-bundling'... [17:50:41] Finished subtask 'configure-webpack-external-bundling' after 1.63 ms [17:50:41] Starting subtask 'copy-assets'... [17:50:41] Error - [copy-assets] TypeError: Cannot read property 'id' of undefined [17:50:41] Error - 'copy-assets' sub task errored after 4.89 ms Cannot read property 'id' of undefined`

wobba commented 4 years ago

Can you try to build react-script-editor-onprem instead, as it will also work online. At least as a work-around.

tejasthite commented 4 years ago

@wobba , okay you mean i can implement react-script-editor-onprem solution with sharePoint online as well after building it? i am specifically looking for the script editor for modern pages if this will help i am happy to do it! Thank you

wobba commented 4 years ago

@tejasthite the onprem version uses SPFx v1.4.1. The other is upgraded to SPFx v1.10 and does thus not work for onprem. When upgrading to SPFx v1.10 I also did some updates to the edit UX.

But they have the same functionality. If the 1.4.1 (on prem supported one) builds for you, use that, as anything working in modern for onprem also works in SPO. All in the top of the readme file in both solutions.

tejasthite commented 4 years ago

@wobba for some reason i am not able to clone this sp-dev-fx-webparts/samples/react-script-editor-onprem/ It keeps asking me for the credentials, i did clone the entire sp-dev-fx-webparts/samples/ But for some reason it did not clone the onprem sample.

wobba commented 4 years ago

git clone https://github.com/SharePoint/sp-dev-fx-webparts.git will clone it all and include both samples in separate folders.

tejasthite commented 4 years ago

@wobba - This looks to be executing as required, I see that webpart as well loaded, how do i build this and take it onto the SP Online for modern pages and add it in there?

Build target: DEBUGv-fx-webparts\samples\react-script-editor-onprem> gulp serve [19:50:41] Using gulpfile C:\Project\sp-dev-fx-webparts\samples\react-script-editor-onprem\gulpfile.js [19:50:41] Starting gulp [19:50:41] Starting 'serve'... [19:50:41] Starting subtask 'configure-sp-build-rig'... [19:50:41] Finished subtask 'configure-sp-build-rig' after 20 ms [19:50:41] Starting subtask 'spfx-serve'... Starting api server on port 5432. Registring api: /getwebparts Registring api: /. Registring api: /workbench [19:50:44] Finished subtask 'spfx-serve' after 2.68 s [19:50:44] Starting subtask 'pre-copy'... [19:50:44] Finished subtask 'pre-copy' after 99 ms [19:50:44] Starting subtask 'copy-static-assets'... [19:50:44] Starting subtask 'sass'... [19:50:50] Server started https://localhost:4321 [19:50:50] LiveReload started on port 35729 [19:50:50] Opening https://localhost:5432/workbench using the default OS app [19:50:50] Finished subtask 'sass' after 6.47 s [19:50:50] Starting subtask 'tslint'... [19:50:54] Starting subtask 'typescript'... [19:50:54] [typescript] TypeScript version: 2.4.2 Request: [::1] '/workbench' [19:50:54] Finished subtask 'copy-static-assets' after 10 s Warning: no-duplicate-case rule is deprecated. Replace your usage with the TSLint no-duplicate-switch-case rule. Warning: valid-typeof rule is deprecated. Replace your usage with the TSLint typeof-compare rule. Request: '/temp/workbench.html' Request: '/temp/manifests.js' Request: '/node_modules/@microsoft/sp-webpart-workbench/node_modules/@microsoft/sp-loader/dist/sp-loader-assembly_en-us.js' Request: '/node_modules/@microsoft/sp-webpart-workbench/lib/api/workbenchInit.js' [19:50:55] Finished subtask 'tslint' after 4.43 s [19:50:56] Finished subtask 'typescript' after 1.89 s [19:50:56] Starting subtask 'ts-npm-lint'... [19:50:56] Finished subtask 'ts-npm-lint' after 23 ms [19:50:56] Starting subtask 'api-extractor'... [19:50:56] Finished subtask 'api-extractor' after 572 μs [19:50:56] Starting subtask 'post-copy'... [19:50:56] Finished subtask 'post-copy' after 280 μs [19:50:56] Starting subtask 'collectLocalizedResources'... [19:50:56] Finished subtask 'collectLocalizedResources' after 333 μs [19:50:56] Starting subtask 'configure-webpack'... [19:50:58] Finished subtask 'configure-webpack' after 2.58 s [19:50:58] Starting subtask 'webpack'... Request: '/node_modules/@microsoft/sp-webpart-workbench/lib/api/assets/server-icon.png' [19:51:05] Finished subtask 'webpack' after 6.41 s [19:51:05] Starting subtask 'configure-webpack-external-bundling'... [19:51:05] Finished subtask 'configure-webpack-external-bundling' after 968 μs [19:51:05] Starting subtask 'copy-assets'... [19:51:06] Finished subtask 'copy-assets' after 1.2 s [19:51:06] Starting subtask 'write-manifests'... [19:51:08] Finished subtask 'write-manifests' after 1.52 s [19:51:08] Starting subtask 'reload'... [19:51:08] Finished subtask 'reload' after 1.3 ms Request: '/temp/workbench.html' Request: '/temp/manifests.js' Request: '/node_modules/@microsoft/sp-webpart-workbench/node_modules/@microsoft/sp-loader/dist/sp-loader-assembly_en-us.js' Request: '/node_modules/@microsoft/sp-webpart-workbench/lib/api/workbenchInit.js' Request: '/node_modules/@microsoft/decorators/dist/decorators.js' Request: '/node_modules/@microsoft/sp-webpart-base/node_modules/@microsoft/sp-http/dist/sp-http_en-us.js' Request: '/node_modules/@microsoft/sp-webpart-base/node_modules/@microsoft/sp-page-context/dist/sp-page-context.js' Request: '/node_modules/@microsoft/sp-component-base/dist/sp-component-base.js' Request: '/node_modules/@microsoft/sp-extension-base/dist/sp-extension-base_en-us.js' Request: '/node_modules/@microsoft/sp-application-base/dist/sp-application-base_en-us.js' Request: '/node_modules/react/dist/react.js' Request: '/node_modules/react-dom/dist/react-dom.js' Request: '/node_modules/@microsoft/sp-webpart-base/node_modules/@microsoft/office-ui-fabric-react-bundle/dist/office-ui-fabric-react-bundle.js' Request: '/node_modules/@microsoft/sp-webpart-base/dist/sp-webpart-base_en-us.js' Request: '/node_modules/@microsoft/sp-webpart-workbench/dist/sp-webpart-workbench_en-us.js' Request: '/temp/workbench.html' Request: '/temp/manifests.js' Request: '/node_modules/@microsoft/sp-webpart-workbench/node_modules/@microsoft/sp-loader/dist/sp-loader-assembly_en-us.js' Request: '/node_modules/@microsoft/sp-webpart-workbench/lib/api/workbenchInit.js' Request: '/node_modules/@microsoft/decorators/dist/decorators.js' Request: '/node_modules/@microsoft/sp-webpart-base/node_modules/@microsoft/sp-http/dist/sp-http_en-us.js' Request: '/node_modules/@microsoft/sp-webpart-workbench/lib/api/assets/server-icon.png' Request: '/node_modules/@microsoft/sp-webpart-base/node_modules/@microsoft/sp-page-context/dist/sp-page-context.js' Request: '/node_modules/@microsoft/sp-component-base/dist/sp-component-base.js' Request: '/node_modules/@microsoft/sp-extension-base/dist/sp-extension-base_en-us.js' Request: '/node_modules/@microsoft/sp-application-base/dist/sp-application-base_en-us.js' Request: '/node_modules/react/dist/react.js' Request: '/node_modules/react-dom/dist/react-dom.js' Request: '/node_modules/@microsoft/sp-webpart-base/node_modules/@microsoft/office-ui-fabric-react-bundle/dist/office-ui-fabric-react-bundle.js' Request: '/node_modules/@microsoft/sp-webpart-base/dist/sp-webpart-base_en-us.js' Request: '/node_modules/@microsoft/sp-webpart-workbench/dist/sp-webpart-workbench_en-us.js'

hugoabernier commented 4 years ago

@tejasthite you may want to look at the Getting started page which should walk you through the entire process. If you don't feel like reading, @PopWarner also created a great video on that same page.

I hope this helps?

tejasthite commented 4 years ago

@hugoabernier thank you very much, yes i have done all the necessary steps, just wanted to confirm as this states as react-script-editor-onprem and i will be uploading this to SharePoint Online App catalog site am i good to proceed or there would be a mismatch?

hugoabernier commented 4 years ago

@tejasthite I see that the README.MD has a slight mistake that says you should upload the .sppkg file to the App Catalog and proceeds to show the URL for SharePoint Online. For the on-prem version, you should upload to your local App Catalog.

I hope this helps?

wobba commented 4 years ago

@tejasthite don't let the naming of the project stop you. Maybe I should have named it react-script-editor-also-works-for-modern-onprem 😉

wobba commented 4 years ago

@hugoabernier I never did create docs for on-prem, merely ensured it was built on a version. I'll tweak the readme to be more specific that it also works for SPO.

tejasthite commented 4 years ago

@wobba @hugoabernier - You people are just Excellent!, Successfully implemented the solution, Thank you very much...

hugoabernier commented 4 years ago

Awesome! I'll go ahead and mark this issue as closed! Thanks @tejasthite for your patience.

And, as always, thanks @wobba for being awesome!

wobba commented 4 years ago

Maybe we'll figure out why this happens at some point - still weird :)

Get-SPadmin commented 3 years ago

Hi there I now am receiving the same errors as @tejasthite but with the employee spotlight webpart. Updated the solution to SPFx 1.11. Any insights?