pnp / sp-dev-fx-webparts

SharePoint Framework web part, Teams tab, personal app, app page samples
http://aka.ms/spfx-webparts
MIT License
2.05k stars 3.86k forks source link

React Enhanced Power Apps: Flexible Height #1674

Open FabianAckeret opened 3 years ago

FabianAckeret commented 3 years ago

I really love the enhanced Power Apps webpart, so first of all a big THANKS for developing it.

Sample

react-enhanced-powerapps (https://github.com/pnp/sp-dev-fx-webparts/tree/master/samples/react-enhanced-powerapps)

Author

Hugo Bernier

Suggestion

If the content of your Power Apps doesn't fit into that defined height of the web part, a second scrollbar appears (1st scrollbar: the one from the browser/SharePoint page and 2nd scrollbar: the one that appeared in the embedded Power Apps). It would be super amazing if there would be a feature to define "flexible height" based on the screen height. If, say, the SharePoint page would get more height depending on the content that is in Power Apps, we wouldn't get that ugly second scrollbar for the app. Despite the suggestion to have Scale to fit on, I turned it off (and replicated responsive design by myself).

ghost commented 3 years ago

Thank you for reporting this issue. We will be triaging your incoming issue as soon as possible.

hugoabernier commented 3 years ago

@FabianAckeret great idea. I'll investigate a way to do it and will try to submit the updated sample as soon as I get an opportunity.