pnp / sp-dev-fx-webparts

SharePoint Framework web part, Teams tab, personal app, app page samples
http://aka.ms/spfx-webparts
MIT License
2.02k stars 3.83k forks source link

react-rss-reader - Feed is not fetched if 'Max Count' is more than 10 #3768

Closed NishkalankBezawada closed 11 months ago

NishkalankBezawada commented 1 year ago

Disclaimer

Yes

Sample

react-rss-reader

Contributor(s)

@Abderahman88 @eoverfield @djsladi

What happened?

The webpart is not fetching results if Max Count setting is changed to more than 10. It works if Max Count is less than 10.

Steps to reproduce

  1. Change the Max Count in property pane of the webpart to more than 10 (Lets say 15)
  2. Click apply
  3. Publish the page, but the feed shows only 10 articles even if we have set this to 15
  4. Change the Max Count in property pane of the webpart to less than 10 (Lets say 5)
  5. Click apply to see the feed
  6. Feed shows 5 articles as set in the Max Count

Expected behavior

  1. Change the Max Count in property pane of the webpart to more than 10 (Lets say 15)
  2. Click apply
  3. Publish the page, The feed should show the count which is set in the Property Pane

Target SharePoint environment

SharePoint Online

Developer environment

None

Browsers

What version of Node.js is currently installed on your workstation?

10.24.1

What version of Node.js is required by the sample?

v10.16.3

Paste the results of SPFx doctor

*

Additional environment details

No response

ghost commented 1 year ago

Thank you for reporting this issue. We will be triaging your incoming issue as soon as possible.

NishkalankBezawada commented 11 months ago

As per the api documentation, the Maxcount is only allowed upto 10. Hence closing the issue

djsladi commented 11 months ago

Just clarifying here to save time in the future: yes, rss2json without api_key is limited to 10 items only. You can sign up to rss2json or even buy some of their plans to have more items.

Direct request doesn't have this limitation, if you can use that option.