pnp / sp-dev-fx-webparts

SharePoint Framework web part, Teams tab, personal app, app page samples
http://aka.ms/spfx-webparts
MIT License
2.03k stars 3.84k forks source link

Custom webpart icons not clearly visible in full-width section #5155

Closed nviolero closed 2 weeks ago

nviolero commented 3 months ago

Disclaimer

Yes

Sample

-

Contributor(s)

-

What happened?

Icons are not clearly visible when you implement a webpart and specifies a title with more than 18 characters and a custom png icon using the property "iconImageUrl".

Steps to reproduce

  1. Create a webpart.
  2. Update preconfiguredEntries in the manifest json with:
  1. Deploy the webpart and try to insert a new one from a full-width section
  2. The custom icon image is not respecting the height of 28px , like the rest of icons. image

SPFX version: 1.18.2

Expected behavior

The icon size should be clearly visible, like the rest of icons, with 28px of height.

Maybe this could be fixed removing the overflow: hidden from this class: image

Target SharePoint environment

SharePoint Online

Developer environment

Windows

Browsers

What version of Node.js is currently installed on your workstation?

18.19.1

What version of Node.js is required by the sample?

18.19.1

Paste the results of SPFx doctor

√ SharePoint Framework v1.18.2 √ Node v18.19.1 √ yo v5.0.0 √ gulp-cli v2.3.0 × typescript v4.7.4 installed in the project

Additional environment details

No response

github-actions[bot] commented 2 weeks ago

This issue has been marked as stale due to no progress in over 90 days. If you are still experiencing this issue, please provide additional information so we can help you resolve it.

nviolero commented 2 weeks ago

This seems to be fixed now.