search

pnp / sp-dev-fx-webparts

SharePoint Framework web part, Teams tab, personal app, app page samples
http://aka.ms/spfx-webparts
MIT License
2.03k stars 3.84k forks source link

React Rhythm of Business Calendar not correctly rendering recurring events on month view #5205

Closed butugruv closed 3 weeks ago

butugruv commented 1 month ago

Disclaimer

Yes

Sample

https://github.com/pnp/sp-dev-fx-webparts/tree/main/samples/react-rhythm-of-business-calendar

Contributor(s)

d-turley

What happened?

Screenshot 2024-08-14 223408

Steps to reproduce

Please see the attached screenshot Screenshot 2024-08-14 223408

Expected behavior

It should show the recurring event on mon and tues. Currently, it only shows on mon.

Target SharePoint environment

SharePoint Online

Developer environment

Windows

Browsers

What version of Node.js is currently installed on your workstation?

16.20.2

What version of Node.js is required by the sample?

16

Paste the results of SPFx doctor

m365: The term 'm365' is not recognized as a name of a cmdlet, function, script file, or executable program. Check the spelling of the name, or if a path was included, verify that the path is correct and try again.

Additional environment details

No response

d-turley commented 4 weeks ago

I think this is the correct behavior. In the screenshot it says the recurrence is set "for 1 occurrence", so after the one instance on Mon the series is done. Does the calendar view on the SharePoint Events list behave differently?

butugruv commented 3 weeks ago

Hi @d-turley, sorry about that I misunderstood how that functionality worked. There is actually a problem when you create an event, be it recurring or single, on a Saturday. It will create a duplicate event that spans the whole following week. I think this has to do with the logic that checks if the event overlaps into the next week.

butugruv commented 3 weeks ago

I think the bug is within builder.ts for in views/month/ folder

butugruv commented 3 weeks ago

it may be related to time zone issues I think, still troubleshooting on my end

butugruv commented 3 weeks ago

Capture2 Capture

butugruv commented 3 weeks ago

@d-turley, In the screenshots above, a Saturday event from 4am-6pm is spanning the whole of the next week when it shouldn't

d-turley commented 3 weeks ago

Thanks for digging into this one. It looks like it's more of a rendering issue in the Month view as opposed to a data issue?

This web part also exists as an app in the store. There is a support e-mail that can help with issues in the published app: ProdStudioHarvesting@microsoft.com

To be blunt, I didn't really intend this SPFx sample code to be just a calendar app. My hope was that people could use the code as a reference solution for building any kind of app with SPFx. It's more a framework that I've been calling the SPFx Solution Accelerator. I've used it to build a wine app for personal use, sort of like cellar tracker. Another idea I've had is to build a RAID log app for project management.

butugruv commented 3 weeks ago

Ah I see. You've done awesome work Daniel!

Actually, I reached out to Julio Lopez Hernandez a couple days ago and he said he would check with the offshore team to see if we could get the source code for the app source version. It looks like there are additional capabilities like the list view in this one which is really nice.