pnp / sp-dev-fx-webparts

SharePoint Framework web part, Teams tab, personal app, app page samples
http://aka.ms/spfx-webparts
MIT License
2.05k stars 3.86k forks source link

Missing .yo-rc.json files in some samples #5332

Open ervingayle opened 2 weeks ago

ervingayle commented 2 weeks ago

Disclaimer

Yes

Sample

https://github.com/pnp/sp-dev-fx-webparts/tree/main/samples/react-accordion-dynamic-section

Contributor(s)

@ejbenke

What happened?

I noticed that the yo-rc.json file is missing from a few samples in the gallery. While this does not affect the functionality of the components, it does impact the ability to leverage the vscode spfx extension actions. Initially, I opened a ticket in that repo but via the discussion, it was recommended that I open an issue here. Here is the discussion: Issue This came to light for me during the recent hacktoberfest and upgrading this solution from an earlier version of SPFx

Steps to reproduce

  1. Download a sample and open it in VS Code
  2. Install VS Code Viva SPFx extension
  3. Open solution in VS Code. Solution actions will not appear along with context actions

Expected behavior

VS Code extension actions should appear

Target SharePoint environment

SharePoint Online

Developer environment

None

Browsers

What version of Node.js is currently installed on your workstation?

18.18.0

What version of Node.js is required by the sample?

18.18.0

Paste the results of SPFx doctor

PS C:\Github\sp-dev-fx-webparts\samples\react-accordion-dynamic-section> m365 spfx doctor -o text

CLI for Microsoft 365 SharePoint Framework doctor Verifying configuration of your system for working with the SharePoint Framework

√ SharePoint Framework v1.20.0 √ Node v18.18.0 √ yo v5.0.0 √ gulp-cli v3.0.0 × typescript v4.7.4 installed in the project

Additional environment details

No response

ervingayle commented 2 weeks ago

I am also able to submit a PR for those samples that are missing this file