pnp / sp-dev-samples

Code samples for SharePoint add-ins, web hooks and other API samples
MIT License
85 stars 129 forks source link

Improving WebHooks.NodeJs sample #18

Closed biste5 closed 7 years ago

biste5 commented 7 years ago
Q A
Bug fix? no
New feature? no
New sample? no -> Improved one
Related issues? no

What's in this Pull Request?

In the sample / helper class TokenHelper.ts, retrieving the source Web when a notification occurs was working reliably when the subscription used to be in a child web, not so reliable when it was on a root web. With this improvement it makes now use of _api/site/openWebById('{webId}') instead, which works better in either case

Some improvements in README to perform admin trust using Azure Portal instead of HTTP request, so that is simpler

VesaJuvonen commented 7 years ago

thx Massimo, appreciated.