search

pnp / sp-dev-solutions

Repository for SharePoint development reusable solutions
Other
500 stars 442 forks source link

Search Refiners checkbox label language is not translated. #238

Open AhmedAldhubaibi opened 5 years ago

AhmedAldhubaibi commented 5 years ago

Category

I am using the modern search web part and I have added a search refiners web part. The problem is that, the result checkbox labels are not being translated.

Hier are my used managed properties for date and size: edit refiners

The results options are being displayed in English:

Englich labels

For the managed properties Created and Size there are no ows_taxid properties. Also There are no labels translation in loc file for these values.

I know that these values (or later, and up ..) are coming form the api search results. Any suggestions?

Authors

@FranckyC @VesaJuvonen

FranckyC commented 5 years ago

Hi @AhmedAldhubaibi, you're right, these values comes directly from the search call response and we don't translate them in the current code. Maybe we could format the output using custom code and current locale for instance, using moment.js. @wobba, can we get these strings according to current locale? Is there any search parameter we can use?

wobba commented 5 years ago

I always assumed query language should impact these. Are we passing lcid on query?

FranckyC commented 5 years ago

Since 3.5.0.0 yes

Télécharger Outlook pour Androidhttps://aka.ms/ghei36

From: Mikael Svenson notifications@github.com Sent: Friday, July 26, 2019 3:37:53 PM To: SharePoint/sp-dev-solutions sp-dev-solutions@noreply.github.com Cc: Franck Cornu franck.cornu@outlook.com; Mention mention@noreply.github.com Subject: Re: [SharePoint/sp-dev-solutions] Search Refiners checkbox label language is not translated. (#238)

I always assumed query language should impact these. Are we passing lcid on query?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHubhttps://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FSharePoint%2Fsp-dev-solutions%2Fissues%2F238%3Femail_source%3Dnotifications%26email_token%3DABLFT4SJISLXGXMPPEGQRXLQBNHBDA5CNFSM4IHDHTJKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD25QYRY%23issuecomment-515574855&data=02%7C01%7C%7C4bcd1c7a226e4f33fa8c08d71200c108%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C636997666750248458&sdata=OvtGZGSyFlJ7YZL5HzwwIzQ7BLj0cgw8H3Ip8%2BFBUy8%3D&reserved=0, or mute the threadhttps://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FABLFT4V5D5UORRSC2TG6XXLQBNHBDANCNFSM4IHDHTJA&data=02%7C01%7C%7C4bcd1c7a226e4f33fa8c08d71200c108%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C636997666750258468&sdata=bRJ93j9f9CHNucdxt6b50G15ZkTAFY6o7cac4VA69ZU%3D&reserved=0.

wobba commented 5 years ago

Did some tests and seems they are always returned in English, which means we need to provide string replacement translations for them:

AhmedAldhubaibi commented 5 years ago

Did some tests and seems they are always returned in English, which means we need to provide string replacement translations for them:

  • From
  • Before
  • up to
  • or later

These phrases and also many others are not the only matter regarding this issue. I mean the core functionality of the search refiners needs to be improved. Consider that the key user wants to filter .docx and .pdf files at the same time, which is not possible in the current logic of the search refiners web part. So as soon as you select .docx another request will immediately occurs to fetch new refiners values for .docx until you soon reaches "any value" refiner. The Size refiner is always returned in Byte values which is somehow a little misleading thing.

So my suggestion is that we actually need to keep the refiner's being dynamically fetched from the search api and at the same time having the possibility to multi filter and be able to use localization for the resources. Something like this:

Suggestion

FranckyC commented 5 years ago

Consider that the key user wants to filter .docx and .pdf files at the same time, which is not possible in the current logic of the search refiners web part.

Or you can select the 'multi-value item refinement' template... The current logic follows the SharePoint one based on classic search web parts. For the 'Size' refiner, it is here a special scenario an yes maybe I should provide a more human readable output format. If you have ideas, don't hesitate to make a PR ;)

AhmedAldhubaibi commented 5 years ago

Consider that the key user wants to filter .docx and .pdf files at the same time, which is not possible in the current logic of the search refiners web part.

Or you can select the 'multi-value item refinement' template... The current logic follows the SharePoint one based on classic search web parts. For the 'Size' refiner, it is here a special scenario an yes maybe I should provide a more human readable output format. If you have ideas, don't hesitate to make a PR ;)

I know that we can use the multi value refiner template, but unfortunately we cannot use two multi filters at the same time since the last one will always overwrite the other/s.

FranckyC commented 5 years ago

I'll see if I can make the 'Apply' button applying all selected filters at once