🐞 [Bug]: Wrong version of node 18 is validated. Should be >= 18.17.1

pnp / vscode-viva

With the SharePoint Framework Toolkit extension, you can create and manage your SharePoint Framework solutions on your tenant. All actions you need to perform during the development flow are at your fingertips.

https://marketplace.visualstudio.com/items?itemName=m365pnp.viva-connections-toolkit

MIT License

34 stars 14 forks source link

🐞 [Bug]: Wrong version of node 18 is validated. Should be >= 18.17.1 #129

Closed Adam-it closed 8 months ago

Adam-it commented 8 months ago

📝 Describe the bug

we validate wrong version of node 18. Currently we validate 18.12 https://github.com/pnp/vscode-viva/blob/340a79c01ed6fd0ac8c320f45dea3fa138a5b08b/src/services/Dependencies.ts#L11C47-L11C47

but should validate >= 18.17.1

📜 Expected behavior

Should validate for node >= 18.17.1

📷 Screenshots

💻 Desktop (please complete the following information):

Version: 2.1