search

pnp / vscode-viva

With the SharePoint Framework Toolkit extension, you can create and manage your SharePoint Framework solutions on your tenant. All actions you need to perform during the development flow are at your fingertips.
https://marketplace.visualstudio.com/items?itemName=m365pnp.viva-connections-toolkit
MIT License
34 stars 14 forks source link

💡 [Feature]: The `Upgrade` and `Validate` actions could return also code tour response #188

Open Adam-it opened 3 months ago

Adam-it commented 3 months ago

🎯 Aim of the feature

As internally those actions use the project upgrade and project doctor CLI for M365 commands and those support also the tour output mode which create a code tour for the current project with the findings. We could extend those functionalities so that we return the markdown sum up report and the tour in one go.

Proposed implementation

In the CliActions service we the upgrade and validate methods. Each of those just run the CLI command under the hood with md output mode. image

Depending on the what user have saved in the setting (see below) we should execute either the command with md or tour output or execute the commands twice with both output for both

Additional Proposal

Similar to node settings we could add additional setting for those features. For each of those features: upgrade and validate we could provide a dropdown with options that define what report type should be generated. Either: markdown (as we have now), code tour, both (which should be the default value) image

nicodecleyre commented 1 week ago

Hi there 👋 , can i work on this one please?

Adam-it commented 1 week ago

Hi there 👋 , can i work on this one please?

Of course