search

pnp / vscode-viva

With the SharePoint Framework Toolkit extension, you can create and manage your SharePoint Framework solutions on your tenant. All actions you need to perform during the development flow are at your fingertips.
https://marketplace.visualstudio.com/items?itemName=m365pnp.viva-connections-toolkit
MIT License
34 stars 14 forks source link

Support for NVS (#180) #199

Closed hugoabernier closed 3 months ago

hugoabernier commented 3 months ago

🎯 Aim

Adds support for NVM, NVS, or no Node Version Manager, and a VS Code Setting to control the choice. As discussed with @VesaJuvonen, needed for upcoming SPFx workshops.

📷 Result

image

✅ What was done

Added a VSCode setting, and logic to change the command when launching a new terminal.

🔗 Related issue

No issues man, we're all good!

Adam-it commented 3 months ago

@hugoabernier Thank you for this awesome suggestion and PR. I rebased the dev branch so that this PR is now clean. Please for future reference start your branch from dev not main to avoid unnecessary conflicts👍 I reviewed your PR and added a few minor comments. Mostly small clean up details. Please double-check them and after they are resolved click on the ready to review button on this PR so we may proceed with merging 👍 Also please do let me know if something is unclear or the SPFx workshop you mentioned is coming shortly and you won't have time to resolve those comments, in that case, I will do that for you 😉. As soon as this is merge I will create a new pre-release so you may start using Viva Toolkit with this change ASAP. I plan to do next minor/major by the end of this month. Cheers.

hugoabernier commented 3 months ago

@Adam-it looks great, please proceed at your convenience

Adam-it commented 3 months ago

Merged manually. Thank you for your awesome work 👏

Adam-it commented 3 months ago

@hugoabernier your change is present in the latest pre-release 2.6.1 🚀 image

remember that in order to install a pre-release you need to click on the switch to pre-release button in the extension view in VS Code to opt-in.

Thank you for contributing to Viva Toolkit 👏