search

pnp / vscode-viva

With the SharePoint Framework Toolkit extension, you can create and manage your SharePoint Framework solutions on your tenant. All actions you need to perform during the development flow are at your fingertips.
https://marketplace.visualstudio.com/items?itemName=m365pnp.viva-connections-toolkit
MIT License
34 stars 14 forks source link

🐛 - Fixed bug when there's a space in the folder path causing serve t… #214

Closed Tanddant closed 2 months ago

Tanddant commented 2 months ago

…o fail

🎯 Aim

Goal is to solve #212

📷 Result

Folder path now wrapped in quotes image

✅ What was done

Hopefully nothing else needs to be done 🙌

🔗 Related issue

Closes: #212

Adam-it commented 2 months ago

@Tanddant thank you for your awesome work 👏. I will try to review it ASAP

Adam-it commented 2 months ago

@Tanddant I marked this as draft as in as we should target all PR's to dev branch first and not to main and also we should start from dev (don't worry about this. I am totally aware the contribution guidance is really minimalistic and I want to work on it this week). Since this branch started from main it now has some changes that should not be here but I will resolve this by rebasing dev against main on this repo, no problem. So in order not to merge this by mistake I set this to draft for that time, just so that you are aware and no action is required from your side 👍.

Adam-it commented 2 months ago

rebased ✅