search

pnp / vscode-viva

With the SharePoint Framework Toolkit extension, you can create and manage your SharePoint Framework solutions on your tenant. All actions you need to perform during the development flow are at your fingertips.
https://marketplace.visualstudio.com/items?itemName=m365pnp.viva-connections-toolkit
MIT License
34 stars 14 forks source link

💡 [Feature]: Refactor scaffolding form to smaller components #221

Closed Adam-it closed 2 weeks ago

Adam-it commented 2 months ago

🎯 Aim of the feature

The aim is to refactor the scaffolding form to a smaller and more reusable components. We could use the gallery view as example

📷 Images (if possible) with expected result

image

🤔 Additional remarks or comments

No response

Saurabh7019 commented 1 month ago

Hi @Adam-it , May I attempt this?

Adam-it commented 1 month ago

Hi @Adam-it , May I attempt this?

Totally!!! All yours 👍. You Rock 🤩 Let me know if you will need any help along the way, currently the build process is a build hacky

Saurabh7019 commented 1 month ago

I think I accidentally unassigned myself. I would still like to work on it and would appreciate it if you could reassign it to me.

Saurabh7019 commented 1 month ago

Also, could you please let me know if there is anything special that needs to be done to be able to debug the extension? My code changes are reflecting but the breakpoints are not currently binding when I hit F5.

Adam-it commented 1 month ago

@Saurabh7019 in order to debug the extension you need to first run npm run watch and after it boots up you should hit f5 in VS Code to reopen a new instance of VS Code with the extension

Saurabh7019 commented 1 month ago

Trying exactly that. Debugging the TypeScript classes are working correctly, but breakpoints in React components are unbound. Anyway, it's not that urgent for my current task, I will look into it later.

Adam-it commented 2 weeks ago

The PR was merged. This refactor will be part of the next minor release. @Saurabh7019 thank you for your awesome work 👏👏👏. You Rock 🤩 As soon as this is merged to main you will also show up as a contributor to the repo 👍

Saurabh7019 commented 2 weeks ago

As soon as this is merged to main you will also show up as a contributor to the repo

Thank you so much. :) It's truly an honor. I'm looking forward to continuing to contribute to this amazing project.