Refactors scaffolding form to smaller components. Closes #221

pnp / vscode-viva

With the SharePoint Framework Toolkit extension, you can create and manage your SharePoint Framework solutions on your tenant. All actions you need to perform during the development flow are at your fingertips.

https://marketplace.visualstudio.com/items?itemName=m365pnp.viva-connections-toolkit

MIT License

34 stars 14 forks source link

Refactors scaffolding form to smaller components. Closes #221 #242

Closed Saurabh7019 closed 2 weeks ago

Saurabh7019 commented 1 month ago

🎯 Aim

This PR refactors scaffolding form to smaller components

📷 Result

✅ What was done

[X] Moved the header section into a separate FormHeader component.
[X] Moved the general information section into a separate GeneralInfoStep component.
[X] Moved the component details section into a separate ComponentDetailsStep component.
[X] Moved the additional steps section into a separate AdditionalStep component.
[X] Moved the form action buttons and the progress indicator into a separate FormActions component.
[X] Maintained the state management within the main component ScaffoldSpfxProjectView.
[X] Added a slight delay to fix terminal receiving pm i instead of npm i when npm install checkbox is selected

🔗 Related issue

Closes: #221

Adam-it commented 1 month ago

@Saurabh7019 thank you for this awesome change 🚀 You rock 🤩 I will review it ASAP

Saurabh7019 commented 3 weeks ago

Hi @Adam-it , I just noticed that the extension loads fine on the main branch, but it doesn’t seem to load on the dev branch. When you have a chance, could you please check if it works for you?

Adam-it commented 3 weeks ago

Hi @Adam-it , I just noticed that the extension loads fine on the main branch, but it doesn’t seem to load on the dev branch. When you have a chance, could you please check if it works for you?

Sure will check, but that's rather strange as latest pre-release 3.2.1 was created from dev branch. So it would not work after downloading from marketplace as well 🤔.

What seems to be the issue?

Saurabh7019 commented 3 weeks ago

What seems to be the issue?

I’m running the watch command on the dev branch and trying to start the extension, but the extension doesn’t show up at all. I don’t see any errors in the debug console that could explain this behavior.

Adam-it commented 3 weeks ago

What seems to be the issue?

I’m running the watch command on the dev branch and trying to start the extension, but the extension doesn’t show up at all. I don’t see any errors in the debug console that could explain this behavior.

I just checked clean dev branch without any changes works ok

in the debug VSCofe instance do you see anything in the extension host output

Saurabh7019 commented 3 weeks ago

I can't seem to figure it out. A fresh clone of the dev branch works fine. I will work with that and make the suggested changes today. I apologize for wasting your time with this.

Adam-it commented 3 weeks ago

I can't seem to figure it out. A fresh clone of the dev branch works fine. I will work with that and make the suggested changes today. I apologize for wasting your time with this.

No apologies needed 👍, all good. From my experience writing VS Code extensions is sometimes glitchy and couple of times already I had those WT* moments as well 😅. Glad that it is working now. Cheers 👍