🐞 Bug report: Unable to Signin from Extension

urwahumer commented 3 weeks ago

⭐ Priority

(Low)☹️ Something is a little off

📝 Describe the bug

I'm encountering an issue signing into M365 using the SPFX toolkit extension. This problem is preventing me from fully leveraging the benefits of the extension. When I click on it, it prompts me to enter the code displayed on my device. However, I don't receive any code. My account has MFA enabled, and even after entering the code from the authenticator app into the Microsoft dialog, I still receive an error.

👣 Steps To Reproduce

I'm encountering an issue signing into M365 using the SPFX toolkit extension. This problem is preventing me from fully leveraging the benefits of the extension. When I click on it, it prompts me to enter the code displayed on my device. However, I don't receive any code. My account has MFA enabled, and even after entering the code from the authenticator app into the Microsoft dialog, I still receive an error.

📜 Expected behavior

Might be Im doing a or looking for wrong way is there any video tuts which can I follow .

📷 Screenshots

No response

❓SharePoint Framework Toolkit version

v3.2.1

❓Node.js version

v18.20.2.

🤔 Additional context

No response

Adam-it commented 3 weeks ago

Thank @urwahumer for reporting an issue. You Rock I will get on it ASAP

Adam-it commented 3 weeks ago

@urwahumer this is how the login 'should' work:

click on the login button in the SPFx Toolkit account panel (alternatively you may use the >SharePoint Framework Toolkit: Sign in to M365 VS Code command)
it will show you a popup where you may allow to open up the browser for you. If you wont allow it you may do it manually afterwards as well.
after that you should see the prompt that explains the login process. It uses Device Code authentication which is default for authentication method. As you may see in the notify you get the device code which BTW is automatically copied for you to the clipboard so you do not need to do that. It should open up your default browser in the MS Device Code login page. If it did not please use the link 'Open Browser to authenticate' which is present in this notify
in the open browser you need to paste the device code. After that login to you tenant (best as admin) and approve the PnP Management Shell app to be added with the required scopes
after that you may close your browser and it should, after a few seconds, show you the management features.

please check the recording below for additional help 👇

https://github.com/pnp/vscode-viva/assets/58668583/76c57367-9414-4d6e-b29b-6ed0c887fa15

Based on this issue I will create a dedicated wiki page to have this info saved for future.

@urwahumer let me know if in your case it is acting differently and let me know how. So we could try to point out the problem. Also if something is not working please do check the logs by going to the output window and showing the output of the SPFx Toolkit

Adam-it commented 3 weeks ago

I extended wiki guidance with this process https://github.com/pnp/vscode-viva/wiki/5.3-Login-to-your-tenant-&-retrieve-environment-details#login-process

urwahumer commented 3 weeks ago

Thank you for your response. I followed your instructions ,now its working fine. Thanks Alot.

On Tue, Jun 4, 2024, 1:12 AM Adam Wójcik @.***> wrote:

I extended wiki guidance with this process

https://github.com/pnp/vscode-viva/wiki/5.3-Login-to-your-tenant-&-retrieve-environment-details#login-process

— Reply to this email directly, view it on GitHub https://github.com/pnp/vscode-viva/issues/244#issuecomment-2146034776, or unsubscribe https://github.com/notifications/unsubscribe-auth/AJIVZWF5D2XZSKYBU2H2PZDZFTEZTAVCNFSM6AAAAABIW4VD76VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCNBWGAZTINZXGY . You are receiving this because you were mentioned.Message ID: @.***>

Adam-it commented 3 weeks ago

Thank you for your response. I followed your instructions ,now its working fine.

Awesome to hear that 👍. Closing this as resolved than. Take care and happy coding 👍

urwahumer commented 3 weeks ago

Great!

On Thu, Jun 6, 2024, 6:43 PM Adam Wójcik @.***> wrote:

Closed #244 https://github.com/pnp/vscode-viva/issues/244 as completed.

— Reply to this email directly, view it on GitHub https://github.com/pnp/vscode-viva/issues/244#event-13067035266, or unsubscribe https://github.com/notifications/unsubscribe-auth/AJIVZWCKLT4RME7AESS7OFLZGBRRPAVCNFSM6AAAAABIW4VD76VHI2DSMVQWIX3LMV45UABCJFZXG5LFIV3GK3TUJZXXI2LGNFRWC5DJN5XDWMJTGA3DOMBTGUZDMNQ . You are receiving this because you were mentioned.Message ID: @.***>

pnp / vscode-viva