pnp / vscode-viva

With the SharePoint Framework Toolkit extension, you can create and manage your SharePoint Framework solutions on your tenant. All actions you need to perform during the development flow are at your fingertips.
https://marketplace.visualstudio.com/items?itemName=m365pnp.viva-connections-toolkit
MIT License
40 stars 17 forks source link

๐Ÿž Bug report: Grant API permissions action works but presents error #264

Open Adam-it opened 4 months ago

Adam-it commented 4 months ago

โญ Priority

(Medium)๐Ÿ˜ข I'm annoyed but I'll live

๐Ÿ“ Describe the bug

the grant API permission action seems to be failing with some cryptic error message image

even though it seems to work properly image

I did some investigation and it seems CLI for Microsoft 365 is failing when running m365 spfx project permissions grant

image

So in order to fix this issue we should first open a bug in CLI for Microsoft 365 and have it fixed there as well. After it will get fixed in that repo we should align our commonjs CLI copy and restest

๐Ÿ‘ฃ Steps To Reproduce

just run Grant API permissions on any SPFx project

๐Ÿ“œ Expected behavior

should grant permissions, this works, but shouldn't present any error message

๐Ÿ“ท Screenshots

added above

โ“SharePoint Framework Toolkit version

3.3.0

โ“Node.js version

18.18.2

๐Ÿค” Additional context

No response

Saurabh7019 commented 4 months ago

Let me look into this issue. Also, I will create a bug report in the CLI repo if one doesn't already exist.

Adam-it commented 4 months ago

Let me look into this issue. Also, I will create a bug report in the CLI repo if one doesn't already exist.

All yours. No the bug on CLI repo still doesn't exist. I didn't have time to add it yet

Saurabh7019 commented 4 months ago

still doesn't exist

actually, it does. https://github.com/pnp/cli-microsoft365/issues/5889

Adam-it commented 4 months ago

still doesn't exist

actually, it does. https://github.com/pnp/cli-microsoft365/issues/5889

AAA awesome, I didn't notice that one. Sorry it is just to much for me sometimes ๐Ÿ˜‰. Now let's resolve it on CLI side and then we may update the CJS version of CLI and it should 'just' work here ๐Ÿ˜…

Adam-it commented 1 day ago

We should wait until the related issue in CLI repo will get fixed