pnpm / action-setup

Install pnpm package manager
https://github.com/marketplace/actions/setup-pnpm
MIT License
887 stars 84 forks source link

Throw error when multiple versions specified #122

Closed karlhorky closed 3 months ago

karlhorky commented 4 months ago

Followup to #33 and #35 by @Jack-Works

Throws error if multiple versions of pnpm are specified, both in:

This will avoid ERR_PNPM_BAD_PM_VERSION errors as documented here:

cc @KSXGitHub

karlhorky commented 3 months ago

@KSXGitHub @zkochan is there anything left to resolve here? Can this be merged?

zkochan commented 3 months ago

I guess this is a breaking change

karlhorky commented 3 months ago

Thanks for the review, the commit improving the robustness of the error condition and merge!

I would also agree that this is a breaking change - I will keep an eye on the releases for v4: