pnpm / action-setup

Install pnpm package manager
https://github.com/marketplace/actions/setup-pnpm
MIT License
904 stars 87 forks source link

[feature request] Use version of pnpm specified in package.json #24

Closed Jack-Works closed 2 years ago

Jack-Works commented 2 years ago

There's two way to specify pnpm version in package.json:

{
  "packageManager": "pnpm@6.23.1",
  "engines": {
    "pnpm": ">=6"
  },
}

It should prefer packageManager field because it is more precise (this field does not support semver).

zkochan commented 2 years ago

TBH, I would be happy to deprecate the engines.pnpm field but I think it is too strict to only allow exact versions in the packageManager field.

Jack-Works commented 2 years ago

I think engines.pnpm is okay since yarn also supports it IIRC (engines.yarn?)