search

pnpm / action-setup

Install pnpm package manager
https://github.com/marketplace/actions/setup-pnpm
MIT License
899 stars 87 forks source link

Deprecation warnings for set-state and set-output commands #57

Closed ghost closed 1 year ago

ghost commented 1 year ago

Seeing the following two warnings when using this action:

The `save-state` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
belgattitude commented 1 year ago

Just proposed two PR's about this

The doc is simple, the action/core update probably needs a second eye.

zkochan commented 1 year ago

Isn't the warning printed by the programmatic usage? https://github.com/pnpm/action-setup/blob/537643d491d20c2712d11533497cb47b2d0eb9d5/src/outputs/index.ts#L8-L9

belgattitude commented 1 year ago

Seing the PR merged into action/core 1.10.0, seems they've updated the internals of setOutput

https://github.com/actions/toolkit/pull/1178/files

My best guess hypothesis is that there's nothing to do apart updating.

Is there a way to test #59 ?

zkochan commented 1 year ago

published v2.2.4

belgattitude commented 1 year ago

Thanks @zkochan, I've tested it and no warnings are emitted anymore. I think this can be closed