search

pnpm / action-setup

Install pnpm package manager
https://github.com/marketplace/actions/setup-pnpm
MIT License
899 stars 87 forks source link

Add major tag `v2` #63

Closed paescuj closed 1 year ago

paescuj commented 1 year ago

What do you think about adding a tag v2 which points to the latest v2 release?

This tag could then also be used in the examples in the README, so that it does not have to be updated with every release.

There is a major tag for v1.

KSXGitHub commented 1 year ago

There's already a v2 branch.

paescuj commented 1 year ago

I see, thanks @KSXGitHub! However, as a user it would be great to have a "stable" major tag which is only updated when there is a new release. As it is done with the checkout action, for example.

KSXGitHub commented 1 year ago

What do you think about editing the examples to use pnpm/action-setup@v2?

/cc @zkochan

zkochan commented 1 year ago

We don't frequently release new versions, so I don't really see the point.

mrienstra commented 1 year ago

I came here to ask about this very thing -- I was confused as to why this GitHub Action suggests specifying an exact (X.Y.Z) version (currently pnpm/action-setup@v2.2.4, with one exception*), when most GitHub Actions seem to suggest specifying only the major version, e.g. actions/checkout@v3.

Would it be difficult to start tagging releases with v2 in addition to e.g. v2.2.4? (Hopefully I'm correct in assuming that would resolve this issue)

Edit: upon further reflection, there is a certain brilliance to asking people to use pnpm/action-setup@v2.2.4 -- that way, every time they look at their GitHub Actions and see it, they'll think: "Huh, I wonder if there's a new patch version of pnpm/action-setup... I'd better pop over and see, and while I'm at it, have a cup of tea and catch up with those wonderful folks that maintain it. Oh, and I might as well see if I can contribute in some way, I'll take a look at the open Issues & PRs, why not! 🫖🙋💭"

*: While I was poking around, noticed one of the three was out of sync: https://github.com/pnpm/action-setup/pull/64

pitgrap commented 1 year ago

Just a stupid question: I'm using "pnpm/action-setup@v2" and that means I'm not using the latest one? :O

KSXGitHub commented 1 year ago

@pitgrap You are using the latest one.

mrienstra commented 1 year ago

@KSXGitHub, I think v2 is currently even with v2.2.3, so slight behind v2.2.4:

(but maybe I'm missing something)

KSXGitHub commented 1 year ago

@mrienstra I see. It seems @zkochan forgot to update v2 when he published v2.2.4. Anyway, v2 is up-to-date now.

mrienstra commented 1 year ago

There are two parts to this issue:

  1. v2 should be kept current: it sounds like this is the intention and generally the case, so it seems like that part of this issue has been resolved for now.
  2. Changing README to show pnpm/action-setup@v2 (drop minor & patch version numbers): where did we land on this? Personally, I think it would reduce confusion. But if the official word is "not changing at this time", then I think this issue can be closed.
KSXGitHub commented 1 year ago

@mrienstra I don't object your second point.

mrienstra commented 1 year ago

Optimistically opened a PR. :)

paescuj commented 1 year ago

Thank you, guys!