search

pnpm / action-setup

Install pnpm package manager
https://github.com/marketplace/actions/setup-pnpm
MIT License
899 stars 87 forks source link

Make `version` optional #85

Closed nicodes closed 1 year ago

nicodes commented 1 year ago

I think the mandatory version should be made optional and default to the latest stable. This will lower the entry barrier for first time users, and can cause confusion with the action version vs pnpm version.

Current:

- uses: pnpm/action-setup@v2
        with:
          version: 7

Proposed:

- uses: pnpm/action-setup@v2
KSXGitHub commented 1 year ago

I would prefer to give pnpm the freedom to make breaking changes without fear of breaking existing CIs.

@zkochan What do you think?

KSXGitHub commented 1 year ago

If version is not specified, packageManager field in package.json would be required. If both don't exist, there would be error.

The reason it was made an error was because we'd like to have the freedom of making breaking changes without fear of breaking existing CIs.