search

pnpm / action-setup

Install pnpm package manager
https://github.com/marketplace/actions/setup-pnpm
MIT License
887 stars 84 forks source link

`v2` not up to date #95

Open privatenumber opened 1 year ago

privatenumber commented 1 year ago

The v2 ref is not pointing to the latest release, which does not contain the latest standalone config documented in the README: https://github.com/pnpm/action-setup/tree/v2

ekwoka commented 11 months ago

I'll add to this:

this repo does not have any major or minor tags, only full version tags. This is not the recommended way to handle these.

Major Versions and minor versions should be tagged and have that tag move to the latest applicable tagged release along with the full major.minor.patch versions.

So now, with 2.4.0 the tags v2 v2.4 and v2.4.0 should all be on the same commit.

This can't be done in a PR, it has to be done by someone with write permissions on the repo.

MikeMcC399 commented 11 months ago

The branch / tag situation has improved, however the v2 branch is at the v2.3.0 release level and does not contain the latest release v2.4.0.

ID type ID commit
branch v2 https://github.com/pnpm/action-setup/commit/0b715c7ebbf3cf2174d1386336c5f6d3d8d5504a
tag v2.4.0 https://github.com/pnpm/action-setup/commit/d882d12c64e032187b2edb46d3a0d003b7a43598
tag v2.3.0 https://github.com/pnpm/action-setup/commit/0b715c7ebbf3cf2174d1386336c5f6d3d8d5504a

It looks like releases are handled in a manual way. You might like to consider automating releases so that branches and tags are automatically updated. Using https://github.com/cycjimmy/semantic-release-action is one way to do this.

zkochan commented 11 months ago

I am sorry. I have merged master to v2 now.

MikeMcC399 commented 11 months ago

@zkochan

I am sorry. I have merged master to v2 now.

Many thanks for correcting this! 👍🏻

@privatenumber

Would you like to check? It looks like this issue can be closed now.

MindTooth commented 3 months ago

Still the case for both v3 and v4. The missing tags makes that e.g. Renovate Bot does not from v3 to v4.

I can help if possible.

DEBUG: github/tags.findCommitOfTag: Tag v3 not found for pnpm/action-setup
DEBUG: Could not determine new digest for update.
{
  "packageName": "pnpm/action-setup"
  "currentValue": "v3"
  "datasource": "github-tags"
  "newValue": "v3"
}
konomae commented 1 month ago

FYI

Official recommendations on versioning: