pnpm / pacquet

experimental package manager for node.js
Apache License 2.0
770 stars 21 forks source link

feat(fs): create `make_file_executable` #168

Closed KSXGitHub closed 1 year ago

KSXGitHub commented 1 year ago

This function is going to be used in https://github.com/pnpm/pacquet/pull/166

codecov[bot] commented 1 year ago

Codecov Report

Attention: 14 lines in your changes are missing coverage. Please review.

Comparison is base (5c866cd) 86.30% compared to head (ac01df0) 85.85%. Report is 1 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #168 +/- ## ========================================== - Coverage 86.30% 85.85% -0.46% ========================================== Files 53 53 Lines 2666 2680 +14 ========================================== Hits 2301 2301 - Misses 365 379 +14 ``` | [Files](https://app.codecov.io/gh/pnpm/pacquet/pull/168?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pnpm) | Coverage Δ | | |---|---|---| | [crates/fs/src/lib.rs](https://app.codecov.io/gh/pnpm/pacquet/pull/168?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pnpm#diff-Y3JhdGVzL2ZzL3NyYy9saWIucnM=) | `30.00% <0.00%> (-70.00%)` | :arrow_down: |

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

github-actions[bot] commented 1 year ago

Micro-Benchmark Results

Linux

group                          main                                   pr
-----                          ----                                   --
tarball/download_dependency    1.01     10.1±2.72ms   428.9 KB/sec    1.00     10.0±4.02ms   435.0 KB/sec
github-actions[bot] commented 1 year ago

Integrated-Benchmark Report (Linux)

Scenario: Frozen Lockfile

Command Mean [ms] Min [ms] Max [ms] Relative
pacquet@HEAD 205.8 ± 22.3 174.4 234.9 1.05 ± 0.16
pacquet@main 195.6 ± 20.7 169.3 228.4 1.00