pnpm / pacquet

experimental package manager for node.js
Apache License 2.0
770 stars 21 forks source link

refactor: parse integrity eagerly #180

Closed KSXGitHub closed 1 year ago

KSXGitHub commented 1 year ago

The parsing of integrity has been moved from tarball to serde.

codecov[bot] commented 1 year ago

Codecov Report

Attention: 5 lines in your changes are missing coverage. Please review.

Comparison is base (fa4638d) 86.43% compared to head (5b203a7) 86.57%. Report is 1 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #180 +/- ## ========================================== + Coverage 86.43% 86.57% +0.14% ========================================== Files 56 56 Lines 2838 2838 ========================================== + Hits 2453 2457 +4 + Misses 385 381 -4 ``` | [Files](https://app.codecov.io/gh/pnpm/pacquet/pull/180?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pnpm) | Coverage Δ | | |---|---|---| | [crates/registry/src/package\_distribution.rs](https://app.codecov.io/gh/pnpm/pacquet/pull/180?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pnpm#diff-Y3JhdGVzL3JlZ2lzdHJ5L3NyYy9wYWNrYWdlX2Rpc3RyaWJ1dGlvbi5ycw==) | `25.00% <ø> (ø)` | | | [crates/tarball/src/lib.rs](https://app.codecov.io/gh/pnpm/pacquet/pull/180?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pnpm#diff-Y3JhdGVzL3RhcmJhbGwvc3JjL2xpYi5ycw==) | `89.72% <100.00%> (+1.96%)` | :arrow_up: | | [...package-manager/src/install\_package\_by\_snapshot.rs](https://app.codecov.io/gh/pnpm/pacquet/pull/180?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pnpm#diff-Y3JhdGVzL3BhY2thZ2UtbWFuYWdlci9zcmMvaW5zdGFsbF9wYWNrYWdlX2J5X3NuYXBzaG90LnJz) | `0.00% <0.00%> (ø)` | | | [crates/lockfile/src/resolution.rs](https://app.codecov.io/gh/pnpm/pacquet/pull/180?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pnpm#diff-Y3JhdGVzL2xvY2tmaWxlL3NyYy9yZXNvbHV0aW9uLnJz) | `96.40% <70.00%> (+0.06%)` | :arrow_up: |

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

github-actions[bot] commented 1 year ago

Micro-Benchmark Results

Linux

group                          main                                   pr
-----                          ----                                   --
tarball/download_dependency    1.00      8.1±0.09ms   532.5 KB/sec    1.03      8.4±0.27ms   517.7 KB/sec
github-actions[bot] commented 1 year ago

Integrated-Benchmark Report (Linux)

Scenario: Frozen Lockfile

Command Mean [ms] Min [ms] Max [ms] Relative
pacquet@HEAD 176.4 ± 18.2 155.1 206.7 1.05 ± 0.13
pacquet@main 168.4 ± 12.9 144.2 187.4 1.00
BENCHMARK_REPORT.json ```json { "results": [ { "command": "pacquet@HEAD", "mean": 0.17636004956181822, "stddev": 0.01819579514305167, "median": 0.17863561538, "user": 0.06561736363636364, "system": 0.10443953636363634, "min": 0.15511080538, "max": 0.20672168638000002, "times": [ 0.20672168638000002, 0.18301107438, 0.16200419638000002, 0.19465632638000002, 0.15600871738, 0.15934356138, 0.17863561538, 0.16270830638, 0.19509193338, 0.15511080538, 0.18666832238 ], "exit_codes": [ 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0 ] }, { "command": "pacquet@main", "mean": 0.16841788963, "stddev": 0.01289534887685345, "median": 0.17170057438000003, "user": 0.07033483333333333, "system": 0.10532973333333333, "min": 0.14424006238, "max": 0.18739573138, "times": [ 0.18739573138, 0.17773210438, 0.17583537938000002, 0.17790610638, 0.15361618638000002, 0.17101491538000002, 0.15448039738, 0.17238623338, 0.14424006238, 0.17972633038000002, 0.15901685738000002, 0.16766437138 ], "exit_codes": [ 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0 ] } ] } ```