pnpm / pacquet

experimental package manager for node.js
Apache License 2.0
770 stars 21 forks source link

refactor: reduce complexity of a function #199

Closed KSXGitHub closed 11 months ago

github-actions[bot] commented 11 months ago

Micro-Benchmark Results

Linux

group                          main                                   pr
-----                          ----                                   --
tarball/download_dependency    1.00      6.7±0.51ms   646.2 KB/sec    1.00      6.7±0.20ms   647.8 KB/sec
codecov[bot] commented 11 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (078359e) 87.11% compared to head (c9ea68d) 87.11%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #199 +/- ## ======================================= Coverage 87.11% 87.11% ======================================= Files 56 56 Lines 2825 2825 ======================================= Hits 2461 2461 Misses 364 364 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

github-actions[bot] commented 11 months ago

Integrated-Benchmark Report (Linux)

Scenario: Frozen Lockfile

Command Mean [ms] Min [ms] Max [ms] Relative
pacquet@HEAD 137.8 ± 12.2 123.9 164.0 1.02 ± 0.13
pacquet@main 134.8 ± 13.0 115.4 163.5 1.00
BENCHMARK_REPORT.json ```json { "results": [ { "command": "pacquet@HEAD", "mean": 0.13776281934, "stddev": 0.01215944005335974, "median": 0.13646048984, "user": 0.053410422857142856, "system": 0.2072166657142857, "min": 0.12389788384, "max": 0.16402255784, "times": [ 0.14430340884, 0.12850677984, 0.13417416384, 0.15373619884, 0.12826517584, 0.14060566984, 0.12658851384, 0.16402255784, 0.12451274484, 0.13874681584, 0.12389788384, 0.14743539484, 0.12830513184, 0.14557903084 ], "exit_codes": [ 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0 ] }, { "command": "pacquet@main", "mean": 0.1347824953066667, "stddev": 0.012974558662485374, "median": 0.13690690384, "user": 0.05659674666666666, "system": 0.20405357999999998, "min": 0.11543505384000001, "max": 0.16345831484, "times": [ 0.14129844484, 0.12689103584, 0.13690690384, 0.12507372184, 0.16345831484, 0.14039973284, 0.14862583584, 0.11999553484, 0.13858490184, 0.12044062684000001, 0.13849801184000002, 0.11543505384000001, 0.14641509684, 0.12289357084000001, 0.13682064284 ], "exit_codes": [ 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0 ] } ] } ```
KSXGitHub commented 11 months ago

Already included in the registry-mock PR.