search

pnpm / pacquet

experimental package manager for node.js
Apache License 2.0
762 stars 21 forks source link

chore(cli): --save-dev with --save-prod implies as dev #216

Open await-ovo opened 9 months ago

await-ovo commented 9 months ago

Behavior consistent with pnpm when --save-dev with --save-prod:

pnpm add some-pkg --save-prod --save-dev will only be installed as devDependencies.

codecov[bot] commented 9 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (c62a631) 92.65% compared to head (75315ef) 92.64%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #216 +/- ## ========================================== - Coverage 92.65% 92.64% -0.02% ========================================== Files 57 57 Lines 2847 2856 +9 ========================================== + Hits 2638 2646 +8 - Misses 209 210 +1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

KSXGitHub commented 9 months ago

I think pnpm is in the wrong in this case, but no one cares enough to fix it yet.

What's your opinion, @zkochan?

zkochan commented 9 months ago

How would you expect it to work at all? I would throw an error in this case.