Closed KSXGitHub closed 9 months ago
All modified and coverable lines are covered by tests :white_check_mark:
Comparison is base (
6d8cec2
) 92.68% compared to head (c2d89d3
) 92.68%.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
group main pr
----- ---- --
tarball/download_dependency 1.01 6.7±0.28ms 650.0 KB/sec 1.00 6.6±0.21ms 654.7 KB/sec
Command | Mean [ms] | Min [ms] | Max [ms] | Relative |
---|---|---|---|---|
pacquet@HEAD |
127.2 ± 9.8 | 114.5 | 144.3 | 1.03 ± 0.11 |
pacquet@main |
123.2 ± 9.8 | 107.5 | 137.7 | 1.00 |
That's fine. Neither pnpm nor the other node.js based alternatives support non-utf8 chars.
Initially, the use of
OsString
was to allow non-UTF8 paths. However, the index file feature requiresserde
which in turns require UTF-8 to serialize. So the need forOsString
ceases to be necessary, and removing it open new opportunities for some micro-optimizations.