fix: run node-gyp rebuild when install is not specified

[etamponi]

The intent was there before, but the code assumed node-gyp was in the node_modules under supi, which might not be the case because of dependency deduping. Instead of doing path incantations, I just rewrite script['install'] to equal the default https://docs.npmjs.com/misc/scripts

[zkochan]

I think using require.resolve to find the node-gyp location would also work

[zkochan]

oh, I just recalled, I moved node-gyp to npm-lifecycle. https://github.com/npm/lifecycle/issues/4

The node-gyp probably can be removed from supi altogether.

[zkochan]

Seems like find-up can be removed as well. And try to install npm-lifecycle instead of @zkochan/npm-lifecycle

They have all the changes pnpm needs. Just rename the module declaration at the end of https://github.com/pnpm/supi/blob/master/typings/local.d.ts and it should work

[etamponi]

Awesome :+1:

Il 24 dic 2017 21:18, "Zoltan Kochan" notifications@github.com ha scritto:

Seems like find-up can be removed as well. And try to install npm-lifecycle instead of @zkochan/npm-lifecycle

They have all the changes pnpm needs. Just renamed module declaration at the end of https://github.com/pnpm/supi/blob/master/typings/local.d.ts and it should work

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/pnpm/supi/pull/28#issuecomment-353801562, or mute the thread https://github.com/notifications/unsubscribe-auth/AAjUNNyo80RBAuzbI1sMd0VSbLLY--HDks5tDrGjgaJpZM4RL_Hi .

[etamponi]

All done! Merry Christmas :)

[zkochan]

Thanks! Merry Christmas to you as well! :christmas_tree:

[etamponi]

squashed all commits into one

[zkochan]

ok, cool. I'll wait for the tests to pass and merge it