search

pnpm / supi

Fast, disk space efficient installation engine. Used by pnpm
MIT License
24 stars 5 forks source link

side effects cache #38

Closed etamponi closed 6 years ago

etamponi commented 6 years ago

Question: --side-effects-cache-readonly should automatically turn --side-effects-cache to true, right? Like, I shouldn't need to do pnpm install --side-effects-cache --side-effects-cache-readonly, but just pnpm install --side-effects-cache-readonly, right?

zkochan commented 6 years ago

Vice versa, --side-effects-cache should turn --side-effects-cache-readonly to true

etamponi commented 6 years ago

What?

etamponi commented 6 years ago

Let me clarify:

  1. pnpm install --side-effects-cache: use & create side effects cache
  2. pnpm install --side-effects-cache-readonly: use & NOT create side effects cache
  3. pnpm install --side-effects-cache --side-effects-cache-readonly: same as previous, but redundant.

That's what I would expect the behaviour to be.

zkochan commented 6 years ago

yes, I agree. The 3rd one could be even an error or a warning

zkochan commented 6 years ago

We should probably add "node" to the side effects cache dirname because it's currently unclear what the v4 at the end means. So something lik linux-x64-node-v4

zkochan commented 6 years ago

:ship: 0.12.0