search

pnpnpn / dna2vec

dna2vec: Consistent vector representations of variable-length k-mers
MIT License
182 stars 60 forks source link

Fix deprecation warning #13

Closed alevenberg closed 4 years ago

alevenberg commented 4 years ago

Fix issue #11

pnpnpn commented 4 years ago

Thanks for creating the PR. The build is failing on python36: https://travis-ci.org/pnpnpn/dna2vec/jobs/642044658?utm_medium=notification&utm_source=github_status

alevenberg commented 4 years ago

It looks like it's getting the error
RuntimeError: Python version >= 3.5 required (https://travis-ci.org/pnpnpn/dna2vec?utm_medium=notification&utm_source=github_status) if looks like only 3.4 is failing because some dependencies require 3.5

pnpnpn commented 4 years ago

You can remove 3.4 support. It's in tox.ini and Travis.yml. Thanks!

alevenberg commented 4 years ago

Sounds good! All fixed up!