pnpnpn / dna2vec

dna2vec: Consistent vector representations of variable-length k-mers
MIT License
182 stars 60 forks source link

Updating DNA2Vec to work with Python 3.7, and to work on Windows 10. #15

Open LightenedLimited opened 4 years ago

LightenedLimited commented 4 years ago

A slight issue that I haven't gotten around to yet is fixing the memory usage, as the packages "resource" is a Unix specific package.

kclejeune commented 4 years ago

A slight issue that I haven't gotten around to yet is fixing the memory usage, as the packages "resource" is a Unix specific package.

Could you elaborate on the memory issue? I'm looking into using this in a unix environment and might be able to help.

LightenedLimited commented 4 years ago

Well, the original author uses the “resource” package to be able to monitor the RAM and CPU usage, but it is an UNIX specific library. If you look at attic_util/util.py, I commented out resources (all it did was return the memory usage) and just returned 0 instead on my branch. If you want to use this feature, just uncomment the relevant areas. By the way, tell me how it goes, I’ve only tested it on windows.

On Thursday, May 21, 2020, Kennan LeJeune notifications@github.com wrote:

A slight issue that I haven't gotten around to yet is fixing the memory usage, as the packages "resource" is a Unix specific package.

Could you elaborate on the memory issue? I'm looking into using this in a unix environment and might be able to help.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/pnpnpn/dna2vec/pull/15#issuecomment-632222657, or unsubscribe https://github.com/notifications/unsubscribe-auth/AGKLDQU2OG6OXFIMVFSP7XLRSVML5ANCNFSM4M7WJTBA .

kclejeune commented 4 years ago

Can you be more specific about what's incompatible in python 3.7?

The existing version of requirements.txt does not correctly install dependencies and causes an error when building with wheels. I think I've mostly resolved this in my pull request.