search

pnpnpn / timeout-decorator

Timeout decorator for Python
MIT License
628 stars 94 forks source link

Fix a bug when using a custom exception with a custom exception message. Also remove tests for Python 3.2 and 3.3. #55

Closed tlalexander closed 5 years ago

tlalexander commented 5 years ago

Fixes #54

Test included. I didn't see how to run the test so hopefully it just passes. :)

tlalexander commented 5 years ago

Hmmm. I fixed the linter error And most of the tests pass now. The tests that fail seem to be failing due to the python version used for those tests, which doesn't seem to be caused by my code. So I think it's good now? I'm new to this system.

tlalexander commented 5 years ago

It looks like tox no longer supports python 3.2 and 3.3, so I've removed those from the tests.

I base my understanding on the comment "tox fails (because setuptools has dropped support for Python 3.3 since v40.0.0)." From this page: https://github.com/noahmorrison/chevron/issues/42

Well... The test just completed as I was writing this comment, and it seems I failed to disable the tests in the way I had intended. I will try to see what I can do here, but perhaps this needs to be fixed by the project owner...

tlalexander commented 5 years ago

Okay! Sorry I missed the .travis.yml as I was only looking in the command line with "ls" and the yml was hidden. Got it sorted! It does look like the tests for python 3.2 and 3.3 should be removed. Hopefully my changes look good.

Thanks!

pnpnpn commented 5 years ago

lgtm. Can you please bump the version to 0.4.1? See https://github.com/pnpnpn/timeout-decorator/commit/2bc336d6ed08eb380f51d249ac33a3d284ae10f4

tlalexander commented 5 years ago

Done. Thanks for the quick response!