pnprog / goreviewpartner

A tool to help analyse and review your game of go (weiqi, baduk) using strong bots.
GNU General Public License v3.0
283 stars 66 forks source link

Feature Request: analysis suspend/resume/update #40

Open liverex opened 6 years ago

liverex commented 6 years ago

Thanks a lot for the awesome software.

Is it possible to implement the feature of analysis suspend/resume/update? I can think of 2 use cases: 1, when the analysis is ongoing, the user has to reboot the computer. 2, the user wants to analyze the whole sgf with the fast profile, and then analyzes some specific moves according to the generated winrate graph with the slow profile.

pnprog commented 6 years ago

Hi! I just want to mention I started looking in this issue. For the moment, I think the best way would be to allow GRP to run on RSGF files.

Currently, when GRP is ran on SGF file, it removes any extra existing variations and keep only the game main line of play (the one selected by the user in fact).

When selecting the SGF files, the file picker applies a filter to SGF files only: file_picker

So maybe I could add a second filter for RSGF extensions, so that, when the file to analyze is a RSGF file, GRP knows that it has to keep the existing variations (and the variation selection would be locked on first variation). Then, there would be an options to skip moves that already have variation (when you want to resume an analysis after computer reboot) or erase/replace existing variations (when to want to analyze again with more thinking time a small subset of moves).

Something like this.

Recently, I ran an analysis of the HayLee vs Leela Zero game, with the same number of play out that during the game. And it took me more than 40 hours (only for HayLee's moves) and at the time, I really wished I had such feature :)

pnprog commented 6 years ago

Hi!

I implemented the feature: https://github.com/pnprog/goreviewpartner/issues/65

Please have a try and let me know :)