pnsaevik / effluent

MIT License
3 stars 1 forks source link

Requirement on dask #17

Closed castelao closed 1 year ago

castelao commented 1 year ago

Hi @pnsaevik , start it!

My first try with pytest failed due to missing dask, which is not currently an explicit dependency. I didn't investigate the details, but it ran fine once I manually installed it in my testing environment. You might need to change your code for an alternative procedure when missing it or add it as an explicit dependency.

FAILED tests/test_io.py::Test_Ambient_from_config::test_roms_file - ValueError: unrecognized chunk manager dask - must be one of: []
FAILED tests/test_roms.py::Test_open_dataset::test_correct_dims_when_multi_file - ValueError: unrecognized chunk manager dask - must be one of: []
FAILED tests/test_roms.py::Test_open_location::test_correct_vars_and_dims - ValueError: unrecognized chunk manager dask - must be one of: []
3 failed, 52 passed, 34 warnings in 26.59s

Somehow related to this, it would be probably a good idea to set up a protection rule in GitHub to run your tests when pushing into the main. If interested, I can guide you through how to do that.