pnsaevik / effluent

MIT License
2 stars 1 forks source link

Optimize ROMS import #51

Closed pnsaevik closed 10 months ago

pnsaevik commented 10 months ago

The previous solution for ROMS import relied on dask. For some reason, the multi-file handling through dask was extremely slow. This PR removes the dask dependency and handles multi-file import from ROMS through a manual concatenation procedure. Although the code becomes slightly more complicated, the benefits outweigh the costs.

pnsaevik commented 10 months ago

In addition, import from ROMS files caused the depth to be read as negative values. This has now been fixed.