search

pnuckowski / aioresponses

Aioresponses is a helper for mock/fake web requests in python aiohttp package.
MIT License
513 stars 86 forks source link

use ClientSession base_url and headers #239

Open rsaleev opened 1 year ago

rsaleev commented 1 year ago

Solves https://github.com/pnuckowski/aioresponses/issues/230

pnuckowski commented 6 months ago

@rsaleev Hi there,

Thank you for your pull request. I appreciate the effort you've put in. However, I regret to inform you that I won't be able to merge this at the moment. There seem to be significant formatting changes, and I couldn't find any accompanying test cases for this alteration.

RafaelWO commented 6 months ago

Thanks for your contribution, @rsaleev!

I am excited to see this be fixed/merged and thus I am happy to help clean up the formatting and add tests - if you are busy with other things :slightly_smiling_face:

rsaleev commented 6 months ago

Thanks for your contribution, @rsaleev!

I am excited to see this be fixed/merged and thus I am happy to help clean up the formatting and add tests - if you are busy with other things :slightly_smiling_face:

Yes, please.

RafaelWO commented 6 months ago

I created a new PR containing only the actual fix (without reformatting code) here: #258

I will add tests as well as soon as if have time :slightly_smiling_face: