search

pnxtech / hydra

A light-weight library for building distributed applications such as microservices
https://www.hydramicroservice.com
MIT License
645 stars 54 forks source link

_checkServicePresence throws a reject although it says it will never do so #176

Closed sjmcdowall closed 6 years ago

sjmcdowall commented 6 years ago

https://github.com/flywheelsports/hydra/blob/master/index.js#L941

According to the "contract" this method should never throw a reject() -- yet it does here:

https://github.com/flywheelsports/hydra/blob/master/index.js#L973

cjus commented 6 years ago

@sjmcdowall correct. ;-) Doc should be corrected to reflect what really happens.

sjmcdowall commented 6 years ago

Fixed by pr # 181