search

pnxtech / hydra

A light-weight library for building distributed applications such as microservices
https://www.hydramicroservice.com
MIT License
645 stars 54 forks source link

Various improvements possible in mocha test cases #178

Closed sjmcdowall closed 6 years ago

sjmcdowall commented 6 years ago

1 -- There appear to be 3 duplicate tests in test.js https://github.com/sjmcdowall/hydra/blob/master/specs/test.js#L182 https://github.com/sjmcdowall/hydra/blob/master/specs/test.js#L239

https://github.com/sjmcdowall/hydra/blob/master/specs/test.js#L198 https://github.com/sjmcdowall/hydra/blob/master/specs/test.js#L255

https://github.com/sjmcdowall/hydra/blob/master/specs/test.js#L219 https://github.com/sjmcdowall/hydra/blob/master/specs/test.js#L276

2 -- Inconsistent use of @description vs. @summary

3 -- No code coverage report appears to be generated. This could be a good thing to see?

cjus commented 6 years ago

Cut and paste no doubt. PR?

sjmcdowall commented 6 years ago

Fixed by https://github.com/flywheelsports/hydra/pull/180