search

pnxtech / hydra

A light-weight library for building distributed applications such as microservices
https://www.hydramicroservice.com
MIT License
645 stars 54 forks source link

Unit test umfmessage #189

Closed sjmcdowall closed 6 years ago

sjmcdowall commented 6 years ago

Added unit tests for umfMessage as a base line. They could be more involved but at least its a start.

@cjus -- Note while writing the tests I believe I noticed two bugs in the actual umfmessage.js code .. so please pay specific attention to that code changes I made and confirm my interpretation of what should be going on is right.

Also -- not sure what to keep doing about that packages-lock.json file .. ??

cjus commented 6 years ago

@sjmcdowall thanks for this! I'm about to test whether the issue you found it indeed a bug.

cjus commented 6 years ago

@sjmcdowall the issue is indeed a bug as it's expected that message routes require the colon separator. I can understand how this hasn't been caught in practice since the use of the segment path is documented as a requirement.