search

pnxtech / hydra

A light-weight library for building distributed applications such as microservices
https://www.hydramicroservice.com
MIT License
645 stars 54 forks source link

avoid creating duplicate redis clients per publish channel #218

Closed cjus closed 3 years ago

cjus commented 3 years ago

This PR seeks to avoid unnecessarily creating duplicate Redis clients per published channel. We discovered the issue at scale at EchelonFit. Warning this PR does need to be extensively tested - which is why it's marked experimental. Thanks to @rjschineller for discovering the issue.

rjschineller commented 3 years ago

Tested over this weekend with a local docker environment - looks stable from my local tests.

We might do a quick smoke test inside our AWS environment to double check our claims.