redis.createClient supports a number of invocation formats:
redis.createClient([options])
redis.createClient(unix_socket[, options])
redis.createClient(redis_url[, options])
redis.createClient(port[, host][, options])
We're currently using 4, but we're not passing through options we don't use. I think it'd be better to use 1, and pass through options from the hydra.redis config entry.
One thing to point out is that we use url instead of host for the host option. url is also a valid redis createClient option (also used by createClient invocation option 3), with format: [redis:]//[[user][:password@]][host][:port][/db-number][?db=db-number[&password=bar[&option=value]]] This could be confusing and we should probably try to be more consistent with the redis options.
At the very least, we should support passing in a password for Redis servers with auth enabled.
emadum
commented
7 years ago
redis.createClient supports a number of invocation formats:
We're currently using 4, but we're not passing through options we don't use. I think it'd be better to use 1, and pass through options from the hydra.redis config entry.
One thing to point out is that we use
urlinstead ofhostfor the host option.urlis also a valid redis createClient option (also used by createClient invocation option 3), with format:[redis:]//[[user][:password@]][host][:port][/db-number][?db=db-number[&password=bar[&option=value]]]This could be confusing and we should probably try to be more consistent with the redis options.At the very least, we should support passing in a password for Redis servers with auth enabled.