[WIP] replace "request" package

[ecwyne]

Currently the request package is used in two fairly simple places. (_tryAPIRequest and _makeAPIRequest)

My initial testing has this PR working for me, though I am not at all sure that it will work in all circumstances. This PR serves to raise the question about rewriting how http requests are performed in hydra.

metrics taken with cost-of-modules

Before

After

Creating a fake request function is not what I would want to push to production, but it seemed to me like rewriting _makeAPIRequest and _tryAPIRequest is above my pay grade at this point. I believe that using the native http library or something like node-fetch would be a better solution long term

[ecwyne]

Also probably worth looking into setting redis and redis-url as peer dependencys in the fwsp-redis-connection package (as they're being loaded twice)

[cjus]

@ecwyne thanks for this callout and the intro to cost-of-modules. I used node-fetch early on and found some issues with sending binary - non-JSON payloads and also with calling external API - Twillio I believe. So I dropped it. That said, any issue I encountered could have been fixed a while ago. I'll have another look.

[cjus]

Currently considering https://github.com/tomas/needle

[ecwyne]

@cjus thanks for the shoutout on twitter!

I looked into needle at first too, but it looked like it would require rewriting _tryAPIRequest and _makeAPIRequest so I didn't pursue them any further myself.

[cjus]

@ecwyne thanks for the heads up on this. I made the changes because I closely understand how request was being used. I also had to test across the services we're using.

The new hydra:1.2.0 is considerably smaller. About 70%.

[ecwyne]

@cjus looks awesome! That's SUBSTANTIALLY smaller, well done!