search

po-devs / po-web

Pokemon Online webclient
11 stars 18 forks source link

Fix more imports, add missing webpack dependency, configure source maps #202

Closed sulcata closed 7 years ago

sulcata commented 7 years ago

Fixed some more of the imports. Added Object.assign for battledata and commandhandling as a temporary fix. Webpack wasn't listed as a devDependency so I added that in.

Source maps will be extremely useful for when we're trying to track down bugs both right now and for any future changes. There's other source map modes we can use (eval, inline, etc.), but I just left the config as simple as possible.

sulcata commented 7 years ago

Oh also path.join is platform agnostic whereas string concatenation opens us up to the potential of all sorts of platform specific issues.