search

po5 / chapterskip

mpv script to skip chapters based on their title
32 stars 7 forks source link

Built-in toggle? #9

Open xfzv opened 10 months ago

xfzv commented 10 months ago

Sometimes I'd like to watch the chapters I usually skip, so I'm using this to quickly toggle the plug-in:

[po5-chapter-skip-disabled]
profile-desc="Disable po5/chapterskip"
profile-restore=copy
script-opts=chapterskip-skip=""
C    script-message cycle-commands "apply-profile po5-chapter-skip-disabled ; show-text `'po5/chapterskip disabled'`" "apply-profile po5-chapter-skip-disabled restore ; show-text `'po5/chapterskip enabled'`"    #! Chapters > Toggle po5/chapterskip

Works just fine. It would be nice if there was a built-in toggle instead of relying on an mpv profile.

In case you don't want to implement this, maybe this could be added to the README. Unless there's a better way, of course.

Thoughts?

po5 commented 9 months ago

How do you expect this to work? Should it disable chapterskip for the current file, until you turn it back on?

xfzv commented 9 months ago

Should it disable chapterskip for the current file, until you turn it back on?

With my current method involving the mpv profile, chapterskip remains disabled when I go to the previous/next file in the playlist until I enable it again with C.

I'm fine with this behavior, but I wouldn't mind if it was only for the current file (and enable it again when going to previous/next file?).

Maybe there are good reasons to prefer this over permanent toggle for the whole "mpv session", I have no opinion on this specifically.

xfzv commented 9 months ago

Eisa01/SmartSkip has this (1 ; 2). The toggle affects the whole mpv session, not just the current file.

The countdown option which allows to cancel the skip with a keybinding is nice too.