search

po5 / evafast

mpv script for hybrid fastforward and seeking
43 stars 1 forks source link

Speed doesn't return to original value #2

Open tomasklaen opened 2 years ago

tomasklaen commented 2 years ago

If my sped is at 1.2, and I use this, it always returns to 1.

po5 commented 2 years ago

I don't know what to do about this, using the defined cap may not suffice and make using the script annoying.
Below is exploring the case where original speed is higher than evafast's caps. Some of these questions also apply for all non-1 original speeds.

Your manually set mpv speed is 2, and your evafast speed 1.5 (original value higher than cap).

Do you expect the speed to slowly go down to 1.5 until you release the right arrow key, and go back to 2?
This seems like the most useless behavior.

Should it always use the higher value between original and evafast, making it have no visible effect in this cases?
Really bad user experience.

Should evafast instead always add "target speed - 1" to your current speed, such that it ramps up to 2.5?
That may be undesirable because the speedup will seem milder as your original speed increases.

Should it multiply your original speed by the target, which in this example gives us 3?
(also applies to previous) It'll be confusing why your defined speed cap isn't being "respected", and would create a dance where you have to turn off your manual speedup, then use evafast, in the right order, to have it produce the speed you defined because it's what works for you.

I want to hear from others what the most desirable behavior would be.

tomasklaen commented 2 years ago

Do you expect the speed to slowly go down to 1.5 until you release the right arrow key, and go back to 2?

Yes.

This seems like the most useless behavior.

But expected one. And you don't know it's useless. Maybe I want to use it as a slow down key :)

The worst thing to do in cases like this is try to be smart and predict how people want to use your app. Just make it go to values I configured. None will complain or be surprised by that.

xfzv commented 2 years ago

Do you expect the speed to slowly go down to 1.5 until you release the right arrow key, and go back to 2?

Yes.

Same here. I would expect speed value to revert to the previous value I manually set (0.5, 1.5, 2.6, whatever) rather than 1 when releasing the right arrow key, it feels more logical to me.

I'm using speed_cap=3.5.

po5 commented 2 years ago

Finally got started on this in #5, I need to rework some things to achieve that effect.